Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post v22.11 deprecation removals #5747

Merged
merged 6 commits into from
Dec 12, 2022
Merged

Post v22.11 deprecation removals #5747

merged 6 commits into from
Dec 12, 2022

Commits on Dec 12, 2022

  1. pay: remove description_hash without description. 

    Deprecated v0.11.0.

Changelog-Removed: JSON-RPC: `pay` for a bolt11 which uses a `description_hash`, without setting `description` (deprecated v0.11.0).
Signed-off-by: Rusty Russell <[email protected]>
    @rustyrussell
    rustyrussell committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    cdbf1af View commit details
    Browse the repository at this point in the history

  2. invoice: expiry must be in seconds. 

    Changelog-Removed: JSON-RPC: `invoice` `expiry` no longer allowed to be a string with suffix, use an integer number of seconds (deprecated v0.11.0)
    @rustyrussell
    rustyrussell committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    73e0669 View commit details
    Browse the repository at this point in the history

  3. wallet: fundpsbt, utxopsbt reserve cannot be bool. 

    Changelog-Removed: JSON-RPC: `fundpsbt`/`utxopsbt` `reserve` must be a number, not bool (deprecated v0.11.0)
Signed-off-by: Rusty Russell <[email protected]>
    @rustyrussell
    rustyrussell committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    5c77615 View commit details
    Browse the repository at this point in the history

  4. lightningd: only allow closing to native segwit 

    Signed-off-by: Rusty Russell <[email protected]>
Changelog-Removed: JSON-RPC: `close` `destination` no longer allows p2pkh or p2sh addresses (deprecated v0.11.0)
    @rustyrussell
    rustyrussell committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    1348054 View commit details
    Browse the repository at this point in the history

  5. sendpay: remove style legacy setting. 

    We ignored it anyway.

Signed-off-by: Rusty Russell <[email protected]>
Changelog-Removed: JSON-RPC: `sendpay` `route` argument `style` "legacy" (deprecated v0.11.0)
    @rustyrussell
    rustyrussell committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    0b6d705 View commit details
    Browse the repository at this point in the history

  6. lightningd: remove setchannelfee. 

    Replaced by `setchannel`.

Signed-off-by: Rusty Russell <[email protected]>
Changlog-Removed: JSON-RPC: `setchannelfee` (deprecated in v0.11.0)
    @rustyrussell
    rustyrussell committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    9cc0a32 View commit details
    Browse the repository at this point in the history