Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the close icon for the verify address dialog #2185

Merged
merged 2 commits into from
Jul 5, 2021

Conversation

neuodev
Copy link
Contributor

@neuodev neuodev commented Jun 22, 2021

  • Added the new cross icon
  • Fix the alignment with the dialog title
  • The old Icon is still thair ( maybe another component using it )
  • the task link on asana

Copy link
Collaborator

@yushih yushih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The position of the cross is still too low on my machine.

To align the cross with the title I need to change top to 0px and margin of svg to 0px.

But then the background shade when hovering needs fixing.

The old icon can be deleted. There are two ways to verify that it is not used:

  1. by doing a grep -r search of the code
  2. by observing that webpack doesn't complain after deleting it.

@neuodev neuodev force-pushed the Ahmed/address-dialog branch 2 times, most recently from c30d20b to 8ce41d6 Compare June 28, 2021 10:01
@neuodev
Copy link
Contributor Author

neuodev commented Jun 28, 2021

The position of the cross is still too low on my machine.

To align the cross with the title I need to change top to 0px and margin of svg to 0px.

But then the background shade when hovering needs fixing.

The old icon can be deleted. There are two ways to verify that it is not used:

  1. by doing a grep -r search of the code
  2. by observing that webpack doesn't complain after deleting it.
  1. Deleted the Icon
  2. you can't make the margin of the svg 0px the close button should be moved up as a single component. So what I did. I applied negative margin on the button so it can be up and align with the title

Copy link
Collaborator

@yushih yushih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works. Thanks!

@vsubhuman vsubhuman added this to the 4.6.0 milestone Jul 5, 2021
Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman vsubhuman merged commit 13ea384 into develop Jul 5, 2021
@vsubhuman vsubhuman deleted the Ahmed/address-dialog branch July 5, 2021 10:55
This was referenced Jul 7, 2021
This was referenced Jul 14, 2021
@vsubhuman vsubhuman mentioned this pull request Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants