-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the close icon for the verify address dialog #2185
Conversation
neuodev
commented
Jun 22, 2021
- Added the new cross icon
- Fix the alignment with the dialog title
- The old Icon is still thair ( maybe another component using it )
- the task link on asana
803d005
to
6f2a2bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The position of the cross is still too low on my machine.
To align the cross with the title I need to change top
to 0px
and margin
of svg
to 0px
.
But then the background shade when hovering needs fixing.
The old icon can be deleted. There are two ways to verify that it is not used:
- by doing a
grep -r
search of the code - by observing that webpack doesn't complain after deleting it.
c30d20b
to
8ce41d6
Compare
|
8ce41d6
to
7427a69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/check