Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cardano dApp-connector : Add read-access functions for cardano #2213

Merged
merged 3 commits into from
Jul 6, 2021
Merged

Cardano dApp-connector : Add read-access functions for cardano #2213

merged 3 commits into from
Jul 6, 2021

Conversation

neuodev
Copy link
Contributor

@neuodev neuodev commented Jul 5, 2021 •
edited
Loading

@vsubhuman vsubhuman changed the title Add read-access functions for cardano Cardano dApp-connector : Add read-access functions for cardano Jul 5, 2021
@vsubhuman vsubhuman requested a review from yushih July 5, 2021 10:22
@vsubhuman vsubhuman added this to the 4.6.0 milestone Jul 5, 2021
vsubhuman
vsubhuman requested changes Jul 5, 2021
View reviewed changes
packages/yoroi-ergo-connector/src/inject.js Outdated Show resolved Hide resolved
packages/yoroi-ergo-connector/src/inject.js Show resolved Hide resolved
packages/yoroi-ergo-connector/src/inject.js Outdated Show resolved Hide resolved
packages/yoroi-ergo-connector/src/inject.js Outdated Show resolved Hide resolved
@neuodev neuodev requested a review from vsubhuman July 6, 2021 10:59
vsubhuman
vsubhuman reviewed Jul 6, 2021
View reviewed changes
Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

rooooooooob
rooooooooob approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@rooooooooob rooooooooob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now for a start, but we should try and share as much of the core RPC framework as reasonable in the future PRs when it's implemented since it should be the same in both specs.

@vsubhuman vsubhuman merged commit de598cc into develop Jul 6, 2021
@vsubhuman vsubhuman deleted the Ahmed/read-access branch July 6, 2021 22:14
This was referenced Jul 7, 2021
Merged
Merged
Closed
This was referenced Jul 14, 2021
Merged
Merged
Merged
@vsubhuman vsubhuman mentioned this pull request Jul 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsubhuman vsubhuman vsubhuman approved these changes

@rooooooooob rooooooooob rooooooooob approved these changes

@yushih yushih Awaiting requested review from yushih

Assignees
No one assigned
Labels
dapp-connector
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@neuodev @rooooooooob @vsubhuman