Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release / 4.21.0 #3203

Merged
merged 65 commits into from
May 24, 2023
Merged

Release / 4.21.0 #3203

merged 65 commits into from
May 24, 2023

Conversation

vsubhuman
Copy link
Contributor

@vsubhuman vsubhuman commented May 12, 2023 •
edited by Nebyt
Loading

yushih and others added 18 commits April 11, 2023 16:42
@yushih
adapt to parsed metadata returned from the backend
57363e4
@yushih @vsubhuman
fix return value when user rejects the connection request from an dApp
f4eabb2
@yushih
hw wallet connector sign tx should not sort inputs
2d1290a
@yushih
mnemonic wallet cip-36
c5d8240
@yushih
hardware wallet cip-36
4569757
@yushih
implement cip 36 voting key generation and remove irrelevant UIs
7032b3f
New CI/CD Pipeline for Octopus Builds
4d30784
This should be working
ed0f826
@vsubhuman
Merge pull request #3202 from Emurgo/production
9796a9b 
[pull] Latest Production to Develop after 4.20.6
@vsubhuman
Merge branch 'develop' into yushi/YOEXT-505/fix-metadata-display-1
ef90362
@vsubhuman
Merge branch 'develop' into yushi/YOEXT-534/dapp-connect-cancel-error
a450129
@vsubhuman
Merge branch 'develop' into yushi/ledger-wallet-connector-fix
5551479
@vsubhuman
Merge branch 'develop' into yushi/YOEXT-574/cip-36
ff2433e
@vsubhuman
Merge pull request #3160 from Emurgo/yushi/YOEXT-505/fix-metadata-dis…
ad6b585 
…play-1

fix transaction metadata display error
@vsubhuman
Merge pull request #3162 from Emurgo/yushi/YOEXT-534/dapp-connect-can…
31be9f3 
…cel-error

fix return value when user rejects the connection request from an dApp
@vsubhuman
Merge pull request #3165 from Emurgo/yushi/ledger-wallet-connector-fix
d812855 
Ledger wallet connector tx signing API should not sort transaction inputs
@vsubhuman
Merge branch 'develop' into yushi/YOEXT-574/cip-36
1401b5a
@vsubhuman
Merge pull request #3176 from Emurgo/yushi/YOEXT-574/cip-36
f921804 
Support CIP 36
@vsubhuman vsubhuman added this to the 4.21.0 milestone May 12, 2023
@vsubhuman vsubhuman self-assigned this May 12, 2023
@neuodev
Copy link
Contributor

neuodev commented May 12, 2023 •
edited
Loading

[autoscript] ⚠️ release/4.21.0 doesn't full our branch naming convention.
Should follow <tag>/<jira-ticket-id>/<short-name>

Details
  • <tag>: fix, feat, chore, refactor, test, ...
  • <jira-ticket-id>: The issue ID of JIRA all capital letters
  • <short-name>: A short and descriptive name for the branch

@vsubhuman vsubhuman requested a review from Nebyt May 12, 2023 15:39
@vsubhuman
Merge remote-tracking branch 'origin/develop' into fix/YOEXT-601/dapp…
c7051de 
…-url

# Conflicts:
#	packages/yoroi-extension/app/components/dapp-connector/ConnectedWebsites/ConnectedWebsitesPage.js
@vsubhuman
i18n file updated
8285109
@vsubhuman
Merge pull request #3205 from Emurgo/fix/YOEXT-601/dapp-url
b39c14a 
fix: add `Intl` & layout fixes for the connected dApps page
@vsubhuman
Merge remote-tracking branch 'origin/develop' into release/4.21.0
f038aec
@vsubhuman
Removed option to create paper (and removed related option dialogs), …
eb838fa 
…removed option to restore ergo, hidden option to restore paper (for now)
@vsubhuman
i18n file updated
27938c3
@vsubhuman
flow fixes
ae9028c
@vsubhuman
lint fixes
447d502
@vsubhuman
few comments added
f7ff0d4
@vsubhuman
Revert "flow fixes"
61ac88b 
This reverts commit ae9028c.
@vsubhuman
rolling back test changes
b470e09
@vsubhuman
Revert "implement cip 36 voting key generation and remove irrelevant …
06050c0 
…UIs"

This reverts commit 7032b3f.
@vsubhuman
Merge pull request #3215 from Emurgo/ruslan/remove-ergo-and-paper-opt…
028f057 
…ions

remove ergo and paper options in create/restore
@vsubhuman
Merge pull request #3219 from Emurgo/ruslan/catalyst-ui-revert
c89a2d2 
Revert Catalyst UI changes
@vsubhuman
Merge remote-tracking branch 'origin/develop' into release/4.21.0
cbcb4b4 
# Conflicts:
#	packages/yoroi-extension/app/containers/wallet/dialogs/voting/VotingRegistrationDialogContainer.js
@vsubhuman
Merge remote-tracking branch 'origin/release/4.21.0' into release/4.21.0
c6be35e
vsubhuman
vsubhuman commented May 23, 2023
View reviewed changes
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman vsubhuman marked this pull request as ready for review May 23, 2023 15:43
Nebyt
Nebyt previously approved these changes May 23, 2023
View reviewed changes
@sonarqube-yoroi
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vsubhuman
Copy link
Contributor Author

Release: https://github.com/Emurgo/yoroi-frontend/releases/tag/4.21.0

@vsubhuman vsubhuman merged commit 3305aa9 into production May 24, 2023
@vsubhuman vsubhuman deleted the release/4.21.0 branch May 24, 2023 15:58
@vsubhuman vsubhuman mentioned this pull request May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nebyt Nebyt Nebyt left review comments

Assignees

@vsubhuman vsubhuman

Labels
release
Projects
None yet
Milestone
4.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@vsubhuman @neuodev @Nebyt @yushih