Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ergo and paper options in create/restore #3215

Merged
merged 7 commits into from
May 22, 2023

Conversation

vsubhuman
Copy link
Contributor

@vsubhuman vsubhuman commented May 19, 2023

@vsubhuman vsubhuman added this to the 4.21.0 milestone May 19, 2023
@vsubhuman vsubhuman requested review from Nebyt and neuodev May 19, 2023 17:54
@neuodev
Copy link
Contributor

neuodev commented May 19, 2023

[autoscript] ⚠️ ruslan/remove-ergo-and-paper-options doesn't full our branch naming convention.
Should follow <tag>/<jira-ticket-id>/<short-name>

Details
  • <tag>: fix, feat, chore, refactor, test, ...
  • <jira-ticket-id>: The issue ID of JIRA all capital letters
  • <short-name>: A short and descriptive name for the branch

Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman vsubhuman mentioned this pull request May 19, 2023
10 tasks
Copy link
Contributor

@Nebyt Nebyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsubhuman Please rollback changes from the folder ../packages/yoroi-extension/features. I will remove outdated info myself.

Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nebyt , /features content is rolled back, /check now plz

@sonarqube-yoroi
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vsubhuman vsubhuman merged commit 028f057 into release/4.21.0 May 22, 2023
@vsubhuman vsubhuman deleted the ruslan/remove-ergo-and-paper-options branch May 22, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants