Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use default export instead of named export #42

Closed
wants to merge 2 commits into from
Closed

fix: use default export instead of named export #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ff1d4d
fix: use default export instead of named export
olafvanv Sep 15, 2021
ed55865
upgrade to esri-leaflet 3.0.2
olafvanv Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"John Gravois <[email protected]> (http://johngravois.com)"
],
"dependencies": {
"esri-leaflet": "^2.0.0",
"esri-leaflet": "^3.0.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change necessary? It does not seem related to the main change in this PR.

Copy link
Author

@olafvanv olafvanv Nov 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esri-leaflet had the same issue. I suppose you have to use an updated version, otherwise you run into the same problem. See Esri/esri-leaflet#1273

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see the dependency change in the PR, unless I'm missing something obvious?
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another option: jgravois/esri-leaflet-gp#46

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any update about this? Currently running into the same issue
@gavinr you mentioned that this was fixed in esri-leaflet v3.0.2 (Esri/esri-leaflet#1273 (comment)) I'm guessing that's why the dependency to esri-leaflet is updated to v3.0.2

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran into the same issue, had to fork this library and force npm to resolve the package to my fork. Without fixing the version import and updating esri-leaflet to 3.0 the library cannot be used in projects built with webpack 5.

"leaflet": "^1.0.0",
"leaflet.markercluster": "^1.0.0"
},
Expand Down
4 changes: 3 additions & 1 deletion src/ClusterFeatureLayer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { setOptions, GeoJSON, markerClusterGroup } from 'leaflet';
import { FeatureManager } from 'esri-leaflet';
export { version as VERSION } from '../package.json';
import packageInfo from '../package.json';
var version = packageInfo.version;
export { version as VERSION };

export var FeatureLayer = FeatureManager.extend({

Expand Down