no-callback fix for jsonp with server error (#1070)

* no-callback fix for jsonp with server error * jsonp unknown error message update
Esri · Mar 23, 2018 · a86cc7d · a86cc7d
1 parent 77a10f8
commit a86cc7d
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/src/Request.js b/src/Request.js
@@ -187,6 +187,20 @@ export function jsonp (url, params, callback, context) {
   script.type = 'text/javascript';
   script.src = url + '?' + serialize(params);
   script.id = callbackId;
+  script.onerror = function (error) {
+    if (error && window._EsriLeafletCallbacks[callbackId] !== true) {
+      // Can't get true error code: it can be 404, or 401, or 500
+      var err = {
+        error: {
+          code: 500,
+          message: 'An unknown error occurred'
+        }
+      };
+
+      callback.call(context, err);
+      window._EsriLeafletCallbacks[callbackId] = true;
+    }
+  };
   DomUtil.addClass(script, 'esri-leaflet-jsonp');
 
   callbacks++;