no-callback fix for jsonp with server error #1070
Conversation
|
All local tests was Ok. |
| // Can't get true error code: it can be 404, or 401, or 500 | ||
| var err = { | ||
| error: { | ||
| code: 500, |
There was a problem hiding this comment.
if we don't know what the actual error was, best not to assign a code arbitrarily.
what about something like this?
var err = {
message: 'An unknown error occurred'
}There was a problem hiding this comment.
Ok, it makes sense. I've just tried to save error contract as
var err = {
error: {
code: 'need something undefined',
message: 'An unknown error occurred'
}
}May be close this PR and make another with correct username and message fix?
And what about failed tests?
There was a problem hiding this comment.
I've just tried to save error contract
meh, this guy seems to agree with you, so i can live with a 500 if you update the message.
May be close this PR and make another with correct username
no need to close this PR. just push another commit to the same branch (and rebase if it'd make you happy).
what about failed tests?
those weren't your fault. i restarted the build and am seeing 💚 now.
* no-callback fix for jsonp with server error * jsonp unknown error message update
Fix for no-callback jsonp request with server error https://github.com/Esri/esri-leaflet/issues/1069 with onerror handler.