Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to PhantomJS 2.x #907

Closed
jgravois opened this issue Dec 29, 2016 · 1 comment · Fixed by #1025
Closed

upgrade to PhantomJS 2.x #907

jgravois opened this issue Dec 29, 2016 · 1 comment · Fixed by #1025

Comments

@jgravois
Copy link
Contributor

see #896 for more info
@jgravois
Copy link
Contributor Author

and investigate ditching mocha, sinon etc. in favor of just using jasmine.

jgravois added a commit that referenced this issue Nov 22, 2017
@jgravois
use Chrome for CI tests instead of phantomjs
ddd5321 
resolves #907 (by omission)

i've long been unable to figure out how to migrate successfully to phantomjs 2.x
without breaking a significant number of tests.

on the contrary, only one real test was sacrificed to take this approach.
the added benefit is that it also resolves #967
@jgravois jgravois mentioned this issue Nov 22, 2017
Merged
jgravois added a commit that referenced this issue Nov 22, 2017
@jgravois
use Chrome for CI tests instead of phantomjs
14e03b6 
resolves #907 (by omission)

i've long been unable to figure out how to migrate successfully to phantomjs 2.x
without breaking a significant number of tests.

on the contrary, only one real test was sacrificed to take this approach.
the added benefit is that it also resolves #967
jgravois added a commit to jgravois/esri-leaflet that referenced this issue Apr 23, 2022
@jgravois
use Chrome for CI tests instead of phantomjs
88797ea 
resolves Esri#907 (by omission)

i've long been unable to figure out how to migrate successfully to phantomjs 2.x
without breaking a significant number of tests.

on the contrary, only one real test was sacrificed to take this approach.
the added benefit is that it also resolves Esri#967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use Chrome for CI tests instead of phantomjs Esri/esri-leaflet
1 participant
@jgravois