Update karma-phantomjs-launcher #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
even though Travis currently targets node v4, tests aren't passing and i can reproduce the same thing locally. these look like pretty much the same errors that crop up when running our test suite on node v6 (#815). apparently there's some interplay between karma and/or phantomjs too. |
|
i've had a heck of a time the last couple days trying to sort out the cause of lots of different test errors. for the time being i'm proposing in #906 that we revert this change and get things sorted in node 6 first, then revisit migrating to karma-phantomjs-launcher 1.0.2 (and consequently PhantomJS 2.x) again very soon. |
jgravois
added a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
Update karma-phantomjs-launcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Issues