Add support for proxy option on BasemapLayer #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgravois
suggested changes
Aug 17, 2018
There was a problem hiding this comment.
very cool! it'd probably be a good idea to add a test for this. come to think of it ImageMapLayer must need one too.
https://github.com/Esri/esri-leaflet/blob/master/spec/Layers/BasemapLayerSpec.js
Strange Travis error
see #1038. if tests are passing locally there's no need to keep pushing commits. i can also refresh the build manually.
|
Wrote a test in #1123 doing a check similar to the check for "token", but I'm not sure it will work well as the proxy script won't exist. |
|
(a belated) thanks for the contribution @dangowans! |
jgravois
pushed a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
Add support for proxy option on BasemapLayer
jgravois
added a commit
to jgravois/esri-leaflet
that referenced
this pull request
Apr 23, 2022
Add support for proxy option on BasemapLayer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help support loading ESRI layers behind Intranet-only restrictions.