Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for proxy to be applied #1123

Closed
wants to merge 2 commits into from
Closed

Test for proxy to be applied #1123

wants to merge 2 commits into from

Conversation

dangowans
Copy link
Contributor

Not really sure this is the best test as the proxy script will not exist.

Pretty sure Travis hates me.
@dangowans
Copy link
Contributor Author

You win Travis. I give.

@jgravois
Copy link
Contributor

jgravois commented Aug 17, 2018

i restarted the build. there's a real error in your new test.

once you get it sorted out, just tack the commit directly on top of the branch you're already working on for #1122

@jgravois jgravois closed this Aug 17, 2018
@dangowans
Copy link
Contributor Author

Definitely over my GitHub head. I have no idea how to "just tack a commit" on another branch.

I've been doing all my testing by simply editing the "esri-leaflet-debug.js" that is packaged with the releases, then recreating the changes in the web editor. Thought that would be sufficient and easier than setting up an entire "esri-leaflet" dev environment.

@jgravois
Copy link
Contributor

everything's relative, but "setting up an entire dev environment" only entails:

  1. git clone https://github.com/Esri/esri-leaflet (or using your UI of choice)
  2. npm install && npm start

https://github.com/Esri/esri-leaflet#development-instructions

if you're interested in a new challenge, we're happy to answer questions. if not, that's okay too. i will find time to write a test and land #1122 eventually.

@jgravois
Copy link
Contributor

oh wow.

travis' only problem with your test was that your actual bug fix wasn't available on this branch.

i cherry picked your work and added it to #1122 myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants