[BUG] Fix runner check at plan execution time for new query planner #1986
clarkzinzowrelease-drafter.yml
on: pull_request
update_release_draft
6s
label
3s
Annotations
2 errors
|
update_release_draft
Validation Failed: {"resource":"Release","code":"invalid","field":"target_commitish"}
{
name: 'HttpError',
id: '6304926789',
status: 422,
response: {
url: 'https://api.github.com/repos/Eventual-Inc/Daft/releases/120823407',
status: 422,
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
connection: 'close',
'content-length': '195',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Mon, 25 Sep 2023 21:11:17 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'GitHub.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-github-permissions': 'contents=write',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-api-version-selected': '2022-11-28',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': '48C7:7E23:AC24D1:15CBE6E:6511F775',
'x-ratelimit-limit': '1000',
'x-ratelimit-remaining': '987',
'x-ratelimit-reset': '1695679860',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '13',
'x-xss-protection': '0'
},
data: {
message: 'Validation Failed',
errors: [
{
resource: 'Release',
code: 'invalid',
field: 'target_commitish'
}
],
documentation_url: 'https://docs.github.com/rest/releases/releases#update-a-release'
}
},
request: {
method: 'PATCH',
url: 'https://api.github.com/repos/Eventual-Inc/Daft/releases/120823407',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'probot/12.2.5 octokit-core.js/3.5.1 Node.js/16.20.1 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"body":"## Changes\\n\\n## ✨ New Features\\n\\n- [FEAT] Add support for windows in daft @samster25 (#1386)\\n- [FEAT] Add debug logging to s3 native apis @samster25 (#1414)\\n- [FEAT] enable path style for s3 custom endpoints by default @samster25 (#1410)\\n- [FEAT] Native S3 Lister, support trailing slashes and fix panics when connection is dropped for tokio @samster25 (#1404)\\n- [FEAT] Native Rust listing of GCS @jaychia (#1392)\\n- [FEAT] [New Query Planner] Enable new query planner by default. @clarkzinzow (#1398)\\n- [FEAT] Parameter to set num\\\\_parallel\\\\_tasks for bulk readers @samster25 (#1399)\\n- [FEAT] Native S3 Client: allow disabling ssl verification or checking hostnames @samster25 (#1395)\\n- [FEAT] Improved projection folding. @xcharleslin (#1374)\\n- [FEAT] bulk parquet pyarrow reader @samster25 (#1396)\\n- [FEAT] Native Recursive File Lister @samster25 (#1353)\\n- [FEAT] Implement .dt.year/month/day for timestamp types @jaychia (#1385)\\n- [FEAT] [New Query Planner] Add support for fsspec filesystems to new query planner. @clarkzinzow (#1357)\\n- [FEAT] Common subexpression elimination in Projection construction @xcharleslin (#1347)\\n\\n## 👾 Bug Fixes\\n\\n- [BUG] [Docs] Allow source code discovery to fail silently for pyo3-defined classes when generating docs. @clarkzinzow (#1430)\\n- [BUG] patch workspace version when building wheels @samster25 (#1418)\\n- [BUG] Anaconda client don\'t upload src wheels @samster25 (#1415)\\n- [BUG] Anaconda client needs wildcard for upload @samster25 (#1413)\\n- [BUG] Fix gs listing to include 0 sized marker files @jaychia (#1412)\\n- [BUG] force upload of anaconda nightly wheels @samster25 (#1411)\\n- [BUG] add test cases for bulk minio reading @samster25 (#1402)\\n- [BUG] Fixes to S3 Native Lister wit
|
|
update_release_draft
HttpError: Validation Failed: {"resource":"Release","code":"invalid","field":"target_commitish"}
at /home/runner/work/_actions/release-drafter/release-drafter/v5/dist/index.js:8462:21
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async Job.doExecute (/home/runner/work/_actions/release-drafter/release-drafter/v5/dist/index.js:30793:18)
{
name: 'AggregateError',
event: {
id: '6304926789',
name: 'pull_request',
payload: {
action: 'edited',
changes: {
body: {
from: "This PR fixes `is_ray_runner` check at plan execution time in the new query planner. Previously, we were checking the Daft context at execution time, which wouldn't be properly set under the Ray runner, since we don't propagate the Daft context to all Ray workers. This PR changes the runner check to be based on an explicit flag passed from the runner to the physical plan execution API."
}
},
number: 1435,
organization: {
avatar_url: 'https://avatars.githubusercontent.com/u/98941975?v=4',
description: 'Eventual Computing',
events_url: 'https://api.github.com/orgs/Eventual-Inc/events',
hooks_url: 'https://api.github.com/orgs/Eventual-Inc/hooks',
id: 98941975,
issues_url: 'https://api.github.com/orgs/Eventual-Inc/issues',
login: 'Eventual-Inc',
members_url: 'https://api.github.com/orgs/Eventual-Inc/members{/member}',
node_id: 'O_kgDOBeW8Fw',
public_members_url: 'https://api.github.com/orgs/Eventual-Inc/public_members{/member}',
repos_url: 'https://api.github.com/orgs/Eventual-Inc/repos',
url: 'https://api.github.com/orgs/Eventual-Inc'
},
pull_request: {
_links: {
comments: {
href: 'https://api.github.com/repos/Eventual-Inc/Daft/issues/1435/comments'
},
commits: {
href: 'https://api.github.com/repos/Eventual-Inc/Daft/pulls/1435/commits'
},
html: { href: 'https://github.com/Eventual-Inc/Daft/pull/1435' },
issue: {
href: 'https://api.github.com/repos/Eventual-Inc/Daft/issues/1435'
},
review_comment: {
href: 'https://api.github.com/repos/Eventual-Inc/Daft/pulls/comments{/number}'
},
review_comments: {
href: 'https://api.github.com/repos/Eventual-Inc/Daft/pulls/1435/comments'
},
self: {
href: 'https://api.github.com/repos/Eventual-Inc/Daft/pulls/1435'
},
statuses: {
href: 'https://api.github.com/repos/Eventual-Inc/Daft/statuses/8d6067bb39e656425ecb28aec0affcfa06381383'
}
},
active_lock_reason: null,
additions: 49,
assignee: null,
assignees: [],
author_association: 'CONTRIBUTOR',
auto_merge: null,
base: {
label: 'Eventual-Inc:main',
ref: 'main',
repo: {
allow_auto_merge: true,
allow_forking: true,
allow_merge_commit: false,
allow_rebase_merge: false,
allow_squash_merge: true,
allow_update_branch: false,
archive_url: 'https://api.github.com/repos/Eventual-Inc/Daft/{archive_format}{/ref}',
archived: false,
assignees_url: 'https://api.github.com/repos/Eventual-Inc/Daft/assignees{/user}',
blobs_url: 'https://api.github.com/repos/Eventual-Inc/Daft/git/blobs{/sha}',
branches_url: 'https://api.github.com/repos/Eventual-Inc/Daft/branches{/branch}',
clone_url: 'https://github.com/Eventual-Inc/Daft.git',
collaborators_url: 'https://api.github.com/repos/Eventual-Inc/Daft/collaborators{/collaborator}',
comments_url: 'https://api.github.com/repos/Eventual-Inc/Daft/comments{/number}',
commits_url: 'https://api.github.com/repos/Eventual-Inc/Daft/commits{/sha}',
compare_url: 'https://api.github.com/repos/Eventual-Inc/Daft/compare/{base}...{hea
|