Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize s3a paths for file writes #2050

Closed
jaychia opened this issue Mar 29, 2024 · 0 comments · Fixed by #2054
Closed

Sanitize s3a paths for file writes #2050

jaychia opened this issue Mar 29, 2024 · 0 comments · Fixed by #2054
Assignees
@jaychia
Labels
p0 Priority 0 - to be addressed immediately

Comments

@jaychia
Copy link
Contributor

jaychia commented Mar 29, 2024 •
edited
Loading

Describe the bug

When writing data, Daft currently cannot handle s3a file paths. We should just sanitinize them to s3

This has to be done also for write_iceberg.
@jaychia jaychia added the p0 Priority 0 - to be addressed immediately label Mar 29, 2024
@jaychia jaychia mentioned this issue Mar 29, 2024
Merged
@jaychia jaychia self-assigned this Mar 29, 2024
jaychia added a commit that referenced this issue Mar 29, 2024
@jaychia
[BUG] Allow for writes to s3a and s3n paths (#2054)
1c590ef 
Closes: #2050

Co-authored-by: Jay Chia <[email protected]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaychia jaychia

Labels
p0 Priority 0 - to be addressed immediately
Projects
No open projects
Daft-OSS
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUG] Allow for writes to s3a and s3n paths Eventual-Inc/Daft
1 participant
@jaychia