Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Allow for writes to s3a and s3n paths #2054

Merged
merged 2 commits into from
Mar 29, 2024
Merged

[BUG] Allow for writes to s3a and s3n paths #2054

merged 2 commits into from
Mar 29, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Mar 29, 2024

Closes: #2050

@github-actions github-actions bot added the bug Something isn't working label Mar 29, 2024
@jaychia jaychia enabled auto-merge (squash) March 29, 2024 21:27
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.72%. Comparing base (de48128) to head (a480d8f).
Report is 1 commits behind head on main.

❗ Current head a480d8f differs from pull request most recent head 43211f8. Consider uploading reports for the commit 43211f8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2054   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files          62       62           
  Lines        6840     6841    +1     
=======================================
+ Hits         5795     5796    +1     
  Misses       1045     1045           
Files Coverage Δ
daft/filesystem.py 60.89% <100.00%> (+0.25%) ⬆️

@jaychia jaychia merged commit 1c590ef into main Mar 29, 2024
29 checks passed
@jaychia jaychia deleted the jay/s3a-paths branch March 29, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sanitize s3a paths for file writes
1 participant