Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Add stubs and improve comments for pyo3-exposed abstractions, + driveby type/bug fixes. #1377

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

clarkzinzow
Copy link
Contributor

@clarkzinzow clarkzinzow commented Sep 14, 2023

This PR adds .pyi stub definitions for all of our pyo3-exposed classes and functions, adds/improves comments for those abstractions, and makes a bunch of driveby type/bug fixes.

The stub definitions enable stronger mypy type-checking and enable code completion for pyo3 abstractions in IDEs.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #1377 (71fa0c8) into main (fc10d6d) will increase coverage by 0.54%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1377      +/-   ##
==========================================
+ Coverage   87.25%   87.80%   +0.54%     
==========================================
  Files          61       60       -1     
  Lines        6059     6025      -34     
==========================================
+ Hits         5287     5290       +3     
+ Misses        772      735      -37     
Files Changed Coverage Δ
daft/__init__.py 26.47% <ø> (+0.15%) ⬆️
daft/logical/schema.py 93.00% <ø> (ø)
daft/runners/runner_io.py 86.66% <ø> (ø)
daft/table/table.py 82.01% <ø> (ø)
daft/context.py 70.52% <100.00%> (+0.63%) ⬆️
daft/io/common.py 90.90% <100.00%> (ø)
daft/logging.py 92.30% <100.00%> (ø)
daft/runners/ray_runner.py 91.20% <100.00%> (+0.02%) ⬆️
daft/udf.py 94.44% <100.00%> (ø)

... and 1 file with indirect coverage changes

daft/daft.pyi Show resolved Hide resolved
daft/io/_parquet.py Outdated Show resolved Hide resolved
@clarkzinzow clarkzinzow merged commit d93dbf7 into main Sep 14, 2023
27 checks passed
@clarkzinzow clarkzinzow deleted the clark/new-query-planner-stubs branch September 14, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants