Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] Add stubs and improve comments for pyo3-exposed abstractions, + driveby type/bug fixes. #1377

Merged
merged 3 commits into from
Sep 14, 2023
Merged

[CHORE] Add stubs and improve comments for pyo3-exposed abstractions, + driveby type/bug fixes. #1377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdb4544
Add stubs and improve comments for pyo3-exposed classes, driveby type…
clarkzinzow Sep 14, 2023
53b6dfa
PR feedback, fix logging frame depth.
clarkzinzow Sep 14, 2023
71fa0c8
Remove dummy daft.daft for mypy.
clarkzinzow Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions daft/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from __future__ import annotations

import os
from typing import TYPE_CHECKING

from daft.logging import setup_logger

Expand Down Expand Up @@ -46,11 +45,6 @@ def get_build_type() -> str:

__version__ = get_version()

if TYPE_CHECKING:
# Placeholder for type checking for Rust module
class daft:
pass


###
# Initialize analytics
Expand Down
5 changes: 4 additions & 1 deletion daft/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,10 @@ def logical_plan_builder_class(self) -> type[LogicalPlanBuilder]:
from daft.logical.logical_plan import PyLogicalPlanBuilder
from daft.logical.rust_logical_plan import RustLogicalPlanBuilder

return RustLogicalPlanBuilder if self.use_rust_planner else PyLogicalPlanBuilder
if self.use_rust_planner:
return RustLogicalPlanBuilder
else:
return PyLogicalPlanBuilder


_DaftContext = DaftContext()
Expand Down
Loading
Loading