Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Enable Progress Bars for PyRunner and RayRunner #1609

Merged
merged 13 commits into from
Nov 17, 2023

dont refresh ray progress bar and set update freq to 1 second

9ce28b9
Select commit
Loading
Failed to load commit list.
Merged

[FEAT] Enable Progress Bars for PyRunner and RayRunner #1609

dont refresh ray progress bar and set update freq to 1 second
9ce28b9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 17, 2023 in 0s

87.29% (+2.69%) compared to 56cd1d6

View this Pull Request on Codecov

87.29% (+2.69%) compared to 56cd1d6

Details

Codecov Report

Merging #1609 (9ce28b9) into main (56cd1d6) will increase coverage by 2.69%.
Report is 13 commits behind head on main.
The diff coverage is 88.17%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1609      +/-   ##
==========================================
+ Coverage   84.59%   87.29%   +2.69%     
==========================================
  Files          54       52       -2     
  Lines        5201     5115      -86     
==========================================
+ Hits         4400     4465      +65     
+ Misses        801      650     -151     
Files Coverage Δ
daft/execution/execution_step.py 91.66% <100.00%> (-0.43%) ⬇️
daft/execution/physical_plan.py 93.37% <100.00%> (+0.39%) ⬆️
daft/runners/pyrunner.py 96.96% <100.00%> (+0.67%) ⬆️
daft/expressions/expressions.py 91.09% <50.00%> (-0.24%) ⬇️
daft/runners/ray_runner.py 89.75% <80.00%> (-0.05%) ⬇️
daft/runners/progress_bar.py 80.48% <80.48%> (ø)

... and 4 files with indirect coverage changes