Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Remove non-MicroPartition and non-ScanOperator paths #1946

Merged
merged 4 commits into from
Feb 24, 2024

Remove Any and trait upcasting from ScanOperator protocol.

3ab8ff3
Select commit
Loading
Failed to load commit list.
Merged

[CHORE] Remove non-MicroPartition and non-ScanOperator paths #1946

Remove Any and trait upcasting from ScanOperator protocol.
3ab8ff3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 24, 2024 in 0s

83.93% (-1.71%) compared to 99db777

View this Pull Request on Codecov

83.93% (-1.71%) compared to 99db777

Details

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.93%. Comparing base (99db777) to head (3ab8ff3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1946      +/-   ##
==========================================
- Coverage   85.63%   83.93%   -1.71%     
==========================================
  Files          55       55              
  Lines        6250     6111     -139     
==========================================
- Hits         5352     5129     -223     
- Misses        898      982      +84     
Files Coverage Δ
daft/execution/execution_step.py 93.23% <100.00%> (-0.44%) ⬇️
daft/execution/physical_plan.py 95.17% <100.00%> (+0.12%) ⬆️
daft/execution/rust_physical_plan_shim.py 93.10% <ø> (-0.72%) ⬇️
daft/io/_csv.py 95.23% <100.00%> (ø)
daft/io/_json.py 100.00% <100.00%> (ø)
daft/io/_parquet.py 100.00% <100.00%> (ø)
daft/logical/builder.py 89.83% <100.00%> (-0.34%) ⬇️
daft/logical/schema.py 91.96% <ø> (+0.58%) ⬆️
daft/plan_scheduler/physical_plan_scheduler.py 75.00% <100.00%> (ø)
daft/runners/pyrunner.py 96.62% <100.00%> (+0.45%) ⬆️
... and 5 more

... and 2 files with indirect coverage changes