Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE]: move list functions from daft-dsl to daft-functions #2854

Merged
merged 17 commits into from
Sep 20, 2024
Merged

[CHORE]: move list functions from daft-dsl to daft-functions #2854

merged 17 commits into from
Sep 20, 2024

Conversation

universalmind303
Copy link
Collaborator

@universalmind303 universalmind303 commented Sep 17, 2024 •
edited
Loading

prerequisite to adding list functions to sql

@universalmind303
remove this file
4f7fe8d
@universalmind303
Merge branch 'main' of https://github.com/Eventual-Inc/Daft
8f1c9e1
@universalmind303
Merge branch 'main' of https://github.com/Eventual-Inc/Daft
b116660
@universalmind303
Merge branch 'main' of https://github.com/Eventual-Inc/Daft
efa8588
@universalmind303
Merge branch 'main' of https://github.com/Eventual-Inc/Daft
1b60c2d
@universalmind303
Merge branch 'main' of https://github.com/Eventual-Inc/Daft
a91b79f
@universalmind303
Merge branch 'main' of https://github.com/Eventual-Inc/Daft
9b303f3
@universalmind303
Merge branch 'main' of https://github.com/Eventual-Inc/Daft
60b4e75
@universalmind303
feat: sql float ops
102ce6b
@universalmind303
register the module
9383213
@universalmind303
Merge branch 'main' of https://github.com/Eventual-Inc/Daft into sql-…
ceec3bd 
…floats
@universalmind303
Merge branch 'main' of https://github.com/Eventual-Inc/Daft into sql-…
7f0752f 
…floats
@universalmind303
Merge branch 'main' of https://github.com/Eventual-Inc/Daft into sql-…
7be1b6b 
…lists
@universalmind303
wip
ea76525
@universalmind303
wip
0d64ba4
@universalmind303
chore: move all list functions from daft-dsl to daft-functions
f4069ff
@github-actions github-actions bot added the chore label Sep 17, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 17, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2854 will degrade performances by 24.21%

Comparing universalmind303:sql-lists (9bf3d09) with main (6766955)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main universalmind303:sql-lists Change
⚡ test_count[1 Small File] 23.7 ms 16.9 ms +40.55%
❌ test_show[100 Small Files] 53.7 ms 70.8 ms -24.21%

@universalmind303 universalmind303 mentioned this pull request Sep 18, 2024
Merged
@jaychia jaychia removed their request for review September 19, 2024 20:52
kevinzwang
kevinzwang approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@universalmind303 universalmind303 merged commit 53dec06 into Eventual-Inc:main Sep 20, 2024
32 of 33 checks passed
universalmind303 added a commit that referenced this pull request Sep 20, 2024
@universalmind303
[FEAT]: sql list operations (#2856)
48a123a 
depends on #2854

you can see the relevant diff
[here](universalmind303/Daft@sql-lists...universalmind303:Daft:sql-lists-2)
@ConeyLiu ConeyLiu mentioned this pull request Oct 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinzwang kevinzwang kevinzwang approved these changes

@raunakab raunakab Awaiting requested review from raunakab

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@universalmind303 @kevinzwang