Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: sql list operations #2856

Merged
merged 22 commits into from
Sep 20, 2024
Merged

[FEAT]: sql list operations #2856

merged 22 commits into from
Sep 20, 2024

Conversation

universalmind303
Copy link
Collaborator

@universalmind303 universalmind303 commented Sep 18, 2024 •
edited
Loading

depends on #2854

you can see the relevant diff here

@universalmind303
remove this file
4f7fe8d
@universalmind303
Merge branch 'main' of https://github.com/Eventual-Inc/Daft
8f1c9e1
@universalmind303
Merge branch 'main' of https://github.com/Eventual-Inc/Daft
b116660
@universalmind303
Merge branch 'main' of https://github.com/Eventual-Inc/Daft
efa8588
@universalmind303
Merge branch 'main' of https://github.com/Eventual-Inc/Daft
1b60c2d
@universalmind303
Merge branch 'main' of https://github.com/Eventual-Inc/Daft
a91b79f
@universalmind303
Merge branch 'main' of https://github.com/Eventual-Inc/Daft
9b303f3
@universalmind303
Merge branch 'main' of https://github.com/Eventual-Inc/Daft
60b4e75
@universalmind303
feat: sql float ops
102ce6b
@universalmind303
register the module
9383213
@universalmind303
Merge branch 'main' of https://github.com/Eventual-Inc/Daft into sql-…
ceec3bd 
…floats
@universalmind303
Merge branch 'main' of https://github.com/Eventual-Inc/Daft into sql-…
7f0752f 
…floats
@universalmind303
Merge branch 'main' of https://github.com/Eventual-Inc/Daft into sql-…
7be1b6b 
…lists
@universalmind303
wip
ea76525
@universalmind303
wip
0d64ba4
@universalmind303
chore: move all list functions from daft-dsl to daft-functions
f4069ff
@universalmind303
fix borked tests
9bf3d09
@universalmind303
wip add sql list functions
eee70e8
@universalmind303
feat: add sql list ops
05a820f
@github-actions github-actions bot added the enhancement New feature or request label Sep 18, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 18, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2856 will degrade performances by 43.43%

Comparing universalmind303:sql-lists-2 (c1fd300) with main (53dec06)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main universalmind303:sql-lists-2 Change
❌ test_count[1 Small File] 9.6 ms 16.9 ms -43.43%
⚡ test_show[100 Small Files] 288.3 ms 113.7 ms ×2.5

kevinzwang
kevinzwang approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one comment to fix an error string

src/daft-sql/src/modules/list.rs Outdated Show resolved Hide resolved
@universalmind303 universalmind303 merged commit 48a123a into Eventual-Inc:main Sep 20, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinzwang kevinzwang kevinzwang approved these changes

@raunakab raunakab Awaiting requested review from raunakab

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@universalmind303 @kevinzwang