[CHORE] fix self clippy lints #2875
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2875 will not alter performanceComparing Summary
|
|
looks good, we should however also add this commit to ignore revs like we do with our last import formatting. This will help preserve the git blame. https://moxio.com/blog/ignoring-bulk-change-commits-with-git-blame/ |
|
@samster25 tbh I am kinda confused 
perhaps GitHub caching issue? ¯_(ツ)_/¯ |
|
@andrewgazelka I believe github runs the CI on the post merge commit. I think you should be fine with rebasing and then merging real real fast |
|
opening separate PR on this repo instead of my personal one #2908 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.