Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] auto-fix prefer Self over explicit type #2908

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Conversation

andrewgazelka
Copy link
Member

No description provided.

@andrewgazelka andrewgazelka changed the title auto-fix self [CHORE] auto-fix prefer Self over explicit type Sep 24, 2024
@github-actions github-actions bot added the chore label Sep 24, 2024
Copy link

codspeed-hq bot commented Sep 24, 2024

CodSpeed Performance Report

Merging #2908 will not alter performance

Comparing andrew/use-clippy (90e377e) with main (d57433a)

Summary

✅ 17 untouched benchmarks

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 72.71815% with 272 lines in your changes missing coverage. Please review.

Project coverage is 78.39%. Comparing base (d57433a) to head (90e377e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-schema/src/dtype.rs 73.33% 36 Missing ⚠️
src/daft-plan/src/display.rs 0.00% 31 Missing ⚠️
src/daft-io/src/s3_like.rs 10.71% 25 Missing ⚠️
src/daft-io/src/lib.rs 22.72% 17 Missing ⚠️
src/daft-io/src/google_cloud.rs 0.00% 12 Missing ⚠️
src/daft-core/src/array/ops/comparison.rs 86.76% 9 Missing ⚠️
src/daft-stats/src/column_stats/comparison.rs 62.50% 9 Missing ⚠️
src/daft-dsl/src/lit.rs 22.22% 7 Missing ⚠️
src/daft-io/src/azure_blob.rs 0.00% 7 Missing ⚠️
src/daft-sql/src/error.rs 25.00% 6 Missing ⚠️
... and 48 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2908      +/-   ##
==========================================
+ Coverage   78.34%   78.39%   +0.04%     
==========================================
  Files         596      596              
  Lines       69875    69675     -200     
==========================================
- Hits        54747    54622     -125     
+ Misses      15128    15053      -75     
Flag Coverage Δ
78.39% <72.71%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/common/daft-config/src/lib.rs 87.50% <100.00%> (ø)
src/common/error/src/python.rs 66.66% <100.00%> (ø)
src/common/io-config/src/s3.rs 53.29% <100.00%> (ø)
src/common/system-info/src/lib.rs 96.15% <100.00%> (ø)
src/daft-core/src/array/fixed_size_list_array.rs 79.58% <100.00%> (ø)
src/daft-core/src/array/image_array.rs 97.56% <100.00%> (ø)
src/daft-core/src/array/list_array.rs 83.53% <100.00%> (ø)
src/daft-core/src/array/mod.rs 71.42% <100.00%> (ø)
src/daft-core/src/array/ops/apply.rs 100.00% <100.00%> (ø)
...c/daft-core/src/array/ops/approx_count_distinct.rs 37.03% <ø> (ø)
... and 161 more

... and 2 files with indirect coverage changes

@samster25
Copy link
Member

We would like to disallow the lint for src/arrow2 and src/parquet since those are forked vendor libraries that we may want to upstream changes in the future.

@jaychia jaychia removed their request for review September 24, 2024 21:41
@samster25 samster25 merged commit 45e2944 into main Sep 25, 2024
36 of 40 checks passed
@samster25 samster25 deleted the andrew/use-clippy branch September 25, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants