[BUG] Pass parquet2 io errors correctly into arrow2 #3012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #3012 will not alter performanceComparing Summary
|
jaychia
reviewed
Oct 7, 2024
samster25
approved these changes
Oct 7, 2024
src/common/error/src/error.rs
Outdated
| @@ -14,7 +14,7 @@ pub enum DaftError { | |||
| #[error("DaftError::ComputeError {0}")] | |||
| ComputeError(String), | |||
| #[error("DaftError::ArrowError {0}")] | |||
| ArrowError(#[from] arrow2::error::Error), | |||
| ArrowError(String), | |||
There was a problem hiding this comment.
This can still hold arrow2::error::Error instead of a string
There was a problem hiding this comment.
Ah gotcha, done
raunakab
approved these changes
Oct 7, 2024
|
Sorry for the regression, folks. I must have accidentally removed a |
- feature flag was incorrect
- incorrectly masked the test!
- parquet2 is required, but *only* as a test dep!
- therefore, added it as a `[dev-dependency]`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 7fe3dbc, two changes were made that caused parquet2 io errors to be mishandled.
Firstly, a
IoErrorfor parquet2 was introduced. However in the implementation ofparquet2::error::Errorforarrow2::error:Error, any parquet2 error that is notFeatureNotActiveorTransportis transformed into anExternalFormaterror.Secondly, arrow2 IO errors are intended to be marked as
ByteStreamErrors, primarily so that they are handled as transient errors and can be retried appropriately. However this special case was removed.This PR makes now classifies parquet2 io errors as arrow2 io errors, and arrow2 io errors are now marked as
ByteStreeamErrors.