Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Pass parquet2 io errors correctly into arrow2 #3012

Merged
merged 5 commits into from
Oct 7, 2024
Merged

[BUG] Pass parquet2 io errors correctly into arrow2 #3012

merged 5 commits into from
Oct 7, 2024

Commits on Oct 7, 2024

  1. Pass parquet2 io errors correctly into arrow2

    @desmondcheongzx
    desmondcheongzx committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    f174983 View commit details
    Browse the repository at this point in the history

  2. Add test

    @desmondcheongzx
    desmondcheongzx committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    710754b View commit details
    Browse the repository at this point in the history

  3. Fix missing trait implementation error

    @raunakab
    raunakab committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    783f4e3 View commit details
    Browse the repository at this point in the history

  4. Add back parquet2 dep; remove feature flagged test 

    - feature flag was incorrect
    - incorrectly masked the test!
- parquet2 is required, but *only* as a test dep!
    - therefore, added it as a `[dev-dependency]`
    @raunakab
    raunakab committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    4630423 View commit details
    Browse the repository at this point in the history

  5. Address review comments

    @desmondcheongzx
    desmondcheongzx committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6b71903 View commit details
    Browse the repository at this point in the history