Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cppcheck fixes #2478

Merged
merged 5 commits into from
Jan 27, 2023
Merged

cppcheck fixes #2478

merged 5 commits into from
Jan 27, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Jan 27, 2023

No description provided.

@ghost
Copy link

ghost commented Jan 27, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@neheb
fix copy constructors
afb2d99 
clang-tidy couldn't transform these because of missing members

Found with cppcheck.

Signed-off-by: Rosen Penev <[email protected]>
@neheb
add missing const
07681ae 
Found with cppcheck

Signed-off-by: Rosen Penev <[email protected]>
@neheb
use find instead of count
e1410b3 
Signed-off-by: Rosen Penev <[email protected]>
@codecov
Copy link

codecov bot commented Jan 27, 2023 •
edited
Loading

Codecov Report

Merging #2478 (a6b4da3) into main (ed67372) will increase coverage by 0.02%.
The diff coverage is 34.48%.

@@            Coverage Diff             @@
##             main    #2478      +/-   ##
==========================================
+ Coverage   62.08%   62.11%   +0.02%     
==========================================
  Files         121      121              
  Lines       22830    22819      -11     
  Branches    11212    11209       -3     
==========================================
- Hits        14175    14173       -2     
+ Misses       6448     6439       -9     
  Partials     2207     2207
Impacted Files Coverage Δ
app/actions.cpp 67.91% <0.00%> (ø)
src/futils.cpp 75.29% <ø> (ø)
src/http.cpp 0.00% <0.00%> (ø)
src/olympusmn_int.cpp 44.68% <ø> (ø)
src/tiffcomposite_int.cpp 77.33% <ø> (+0.95%) ⬆️
src/tiffcomposite_int.hpp 90.26% <0.00%> (-2.47%) ⬇️
src/value.cpp 73.32% <42.85%> (ø)
src/convert.cpp 53.61% <50.00%> (ø)
src/properties.cpp 75.89% <50.00%> (ø)
src/xmp.cpp 77.15% <66.66%> (-0.09%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@neheb
replace substr with resize/pop_back
12bf3fd 
Shorter and more efficient.

Signed-off-by: Rosen Penev <[email protected]>
@neheb
Copy link
Collaborator Author

neheb commented Jan 27, 2023

@piponazo can you check these constructor changes?

@neheb
remove unused variable
a6b4da3 
Signed-off-by: Rosen Penev <[email protected]>
@piponazo piponazo self-requested a review January 27, 2023 06:18
piponazo
piponazo approved these changes Jan 27, 2023
View reviewed changes
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up!

@neheb neheb merged commit a87c59b into Exiv2:main Jan 27, 2023
@neheb neheb deleted the 7 branch January 27, 2023 06:44
@nehaljwani nehaljwani mentioned this pull request May 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piponazo piponazo piponazo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neheb @piponazo