Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cppcheck fixes #2478

Merged
merged 5 commits into from
Jan 27, 2023
Merged

cppcheck fixes #2478

merged 5 commits into from
Jan 27, 2023

Commits on Jan 27, 2023

  1. fix copy constructors 

    clang-tidy couldn't transform these because of missing members

Found with cppcheck.

Signed-off-by: Rosen Penev <[email protected]>
    @neheb
    neheb committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    afb2d99 View commit details
    Browse the repository at this point in the history

  2. add missing const 

    Found with cppcheck

Signed-off-by: Rosen Penev <[email protected]>
    @neheb
    neheb committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    07681ae View commit details
    Browse the repository at this point in the history

  3. use find instead of count 

    Signed-off-by: Rosen Penev <[email protected]>
    @neheb
    neheb committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    e1410b3 View commit details
    Browse the repository at this point in the history

  4. replace substr with resize/pop_back 

    Shorter and more efficient.

Signed-off-by: Rosen Penev <[email protected]>
    @neheb
    neheb committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    12bf3fd View commit details
    Browse the repository at this point in the history

  5. remove unused variable 

    Signed-off-by: Rosen Penev <[email protected]>
    @neheb
    neheb committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    a6b4da3 View commit details
    Browse the repository at this point in the history