Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Seraphim Air Factories being harder to place than other factories #6022

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Fix Seraphim Air Factories being harder to place than other factories #6022

merged 2 commits into from
Mar 28, 2024

Conversation

Basilisk3
Copy link
Collaborator

@Basilisk3 Basilisk3 commented Mar 28, 2024 •
edited
Loading

Description of the proposed changes

FlattenSkirt needs to be set to true, as it is for all other Air Factories. Resolves #5460.

Additinal Context

#4584 set this value to false.

Checklist

  • Changes are documented in the changelog for the next game version

@Garanas
Copy link
Member

Garanas commented Mar 28, 2024

@Hdt80bro or @4z0t could you look into assembly why this particular field impacts the ability to place the structure? It feels to me that it should not

@Garanas Garanas added type: bug area: sim Area that is affected by the Simulation of the Game labels Mar 28, 2024
@Garanas Garanas merged commit 80b61fc into FAForever:deploy/fafdevelop Mar 28, 2024
@Basilisk3 Basilisk3 deleted the Fix_SeraphimAirFactories branch March 28, 2024 21:55
Garanas pushed a commit that referenced this pull request Mar 31, 2024
@Basilisk3 @Garanas
Fix Seraphim Air Factories being harder to place than other factories (…
14f8b81 
…#6022)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: sim Area that is affected by the Simulation of the Game type: bug
Projects
None yet
Milestone
Development iteration I of 2024
Development

Successfully merging this pull request may close these issues.

Seraphim air factories are harder to place than other air factories when terrain deformations are present
2 participants
@Basilisk3 @Garanas