Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for fixing the unintentional situation that since v0.6 the… #404

Merged
merged 6 commits into from
Aug 26, 2024

Commits on Aug 21, 2024

  1. Suggestion for fixing the unintentional situation that since v0.6 the…

    … dataconverter required a config file if it was called the classical way and in case no parameter yaml file was provided. For programmatically use of the converter the creation of an additional params file with only a few entries is unnecessary overhead especially when all cli arguments are available in the callers scope and thus the CLI call can be issues directly using the classical way dataconverter convert [INPUTFILES] options
    atomprobe-tc committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    d272a6d View commit details
    Browse the repository at this point in the history
  2. pynxtools-em and pynxtools-apm readers do not use a config.json that …

    …is passed via cli but instead have their own configurations for the respective formats they support as part of the plugin source code, hence calling these readers with kwargs config is unnecessary and incorrect, this commit fixes this bug
    atomprobe-tc committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    0339602 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    30ad68c View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Configuration menu
    Copy the full SHA
    3fc6f8f View commit details
    Browse the repository at this point in the history
  2. add config_file to kwargs

    lukaspie committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    4bd3539 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Configuration menu
    Copy the full SHA
    5fd863a View commit details
    Browse the repository at this point in the history