Initial Mapping-IO support #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At a glace this looks like a great start. Most of the time we dont use the GUI to select the mappings, in yarn its passed as run argument, or the commands to augment the mappings are directly invoked. It might be nice to have a system property? to make it the default option so we could try it out easily in yarn. |
NebelNidas
force-pushed
the
mapping-io
branch
from
95bb87f
to
031f98b
Compare
modmuss50
reviewed
Nov 19, 2023
modmuss50
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds full Mapping-IO import and export support. It doesn't replace Enigma's own (legacy) import/export code (yet), so you can choose which library to use, in case there are still bugs in the new solution. The CLI defaults to the MIO implementations, this can be changed via the
enigma.use_mappingioSystem property.Closes #402 and supersedes #465.