Make "checkmappings" command support all readable formats #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
requested changes
Sep 24, 2022
Comment on lines
+61
to
+65
| try { | ||
| return format.read(path, progress, saveParameters); | ||
| } catch (Exception e) { | ||
| suppressed.add(e); | ||
| } |
There was a problem hiding this comment.
This is awful, it should detect the format before trying to read it like this.
Mapping-io has a thing to detect mapping formats, either use something similar or come back to this change once moved over to mapping-io.
For now I see little benefit in this PR.
There was a problem hiding this comment.
It's definitely a bit hacky, but since we'll be switching to mapping-io soon anyway, I don't see a point in investing the time to write a proper mapping format detector.
For now I see little benefit in this PR
Users can check other mapping formats for correctness, I think it's worth it ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly taken from QuiltMC/enigma@bad1042.
Fixes #273.