React select bump #384
Closed
React select bump #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The update from Emotion 9 to 10 makes me nervous, we'll need to make sure this builds nicely in FLCOM with SSR before merging this. |
|
No rush. Better to take time to make sure nothing else breaks. |
|
Understood. Thanks for putting the PR together, I'll test it out within FLCOM soonish. |
|
Good news, I was able to get Emotion v10 working nicely in FLCOM, unblocking this version update. I've cherry-picked your commit onto the v6 PR (#413) and will merge it when we're ready to ship v6 (very soon). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated imports according to this guide: JedWatson/react-select#3585