Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6 Roadmap #378

Closed
40 tasks done
RobertBolender opened this issue Oct 12, 2020 · 3 comments
Closed
40 tasks done

v6 Roadmap #378

RobertBolender opened this issue Oct 12, 2020 · 3 comments
Milestone

Comments

@RobertBolender
Copy link
Contributor

RobertBolender commented Oct 12, 2020

v6 goals

  • Can be installed cleanly on top of v5
  • Can have multiple versions installed without conflicts (no global CSS files, etc)
  • Should be installed as a direct dependency rather than a peer dependency

v6 roadmap

Shortly after shipping v6

  • Storybook / docs upgrade (draft PR Add storybook docs #397)
  • Jest unit tests with React-Testing-Library
    • Prefer to co-locate tests within component directories, such as Button.jsx and Button.test.jsx adjacent to each other.
    • Test that all components render without crashing
    • Test that all components can transition to all appropriate states without crashing (isOpen, isClosed, toggles, etc.)
    • Test that components can render without crashing even if rendered outside of a global theme provider

Further down the road

  • Visual Regression / Snapshot Testing (Still under internal discussion, considering Percy or jest-image-snapshot for visual regression testing)
@TyMick
Copy link
Collaborator

TyMick commented Dec 17, 2020

Is there a standard set of Styled System prop categories that we want all components to use? At the moment I'm only adding to each v6 component the Styled System categories that are directly needed to replace some functionality being removed from the v5 version.

Should I add our common collection to each of them?

export const common = compose(
styledSystem.space,
styledSystem.color,
styledSystem.display,
styledSystem.system({
pointerEvents: true,
transform: true,
transition: true,
}),
);

Maybe typography as well to the components that contain text?

export const typography = compose(
styledSystem.typography,
styledSystem.system({
textTransform: true,
whiteSpace: true,
textOverflow: true,
}),
);

@RobertBolender
Copy link
Contributor Author

Is there a standard set of Styled System prop categories that we want all components to use?

Not yet, although adding common and typography as appropriate as you suggested sounds like a good idea.

@RobertBolender
Copy link
Contributor Author

Closed with #413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants