Create v6 SimpleToast with Styled System #400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another #378— Here's a v6
SimpleToast
that replaces thestyleOverrides
prop with Styled System utilities for color, layout, and position. I also replaced an oldtheme
prop to use the new Styled System theme instead.The most notable changes are in
styled.jsx
. In it, since the default styles include a media query, I placed the Styled System primitives inside an&&
block:This way, if a developer assigns a single value instead of an array to any of those Styled System props, meaning for that single value to apply across all screen width breakpoints, this
&&
specificity will ensure it wins any conflicts with defaults inside in the media query.