Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create v6 ParameterSentence components with Styled System #410

Merged
merged 15 commits into from
Jan 11, 2021

Conversation

TyMick
Copy link
Collaborator

@TyMick TyMick commented Dec 13, 2020

Rolling along on #378 🚗

Just a draft at the moment. ParameterSentence and ParameterInputBox are ready, but working on ParameterSelect raised some questions about Listbox that need to be resolved first. I'm going to bring that up in a new issue (#411).

In the meantime, though, one change in here that may seem unrelated at first glance is in components/utils/filter-props.js. I was about to build something similar while adapting ParameterInputBox when I noticed this file and that its filterChildProps function was very close to what I needed. I saw it wasn't being used anywhere in the project, so I took the liberty of adapting it to a slightly more general purpose, renaming it to just filterProps (though it can still be used for filtering child props specifically). Hope that's cool. 👍🏼

@TyMick TyMick marked this pull request as draft December 13, 2020 06:38
@RobertBolender RobertBolender mentioned this pull request Dec 22, 2020
40 tasks
@TyMick
Copy link
Collaborator Author

TyMick commented Jan 4, 2021

I've updated ParameterSelect now with the Listbox changes I'm expecting, just passing Styled System props instead of the old styledOverrides prop. Once @korbinancell's v6 Listbox is ready (see #411), I'll make one last sweep here to make sure ParameterSelect is compatible with the new API, then I'll update the Catalog documentation, and then this PR should be ready to go. 👍🏼

@RobertBolender
Copy link
Contributor

I've updated ParameterSelect now with the Listbox changes I'm expecting, just passing Styled System props instead of the old styledOverrides prop. Once @korbinancell's v6 Listbox is ready (see #411), I'll make one last sweep here to make sure ParameterSelect is compatible with the new API, then I'll update the Catalog documentation, and then this PR should be ready to go. 👍🏼

I think that we can go ahead and get this PR merged first, then follow-up with any necessary changes to the v6 ParameterSelect once the Listbox changes are in.
Without objection, I'll merge this tomorrow.

@TyMick
Copy link
Collaborator Author

TyMick commented Jan 5, 2021

Sounds good!

@TyMick TyMick marked this pull request as ready for review January 5, 2021 19:09
TyMick added a commit to TyMick/styled-ui that referenced this pull request Jan 7, 2021
@RobertBolender RobertBolender merged commit 74906fb into Faithlife:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants