-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create v6 ParameterSentence components with Styled System #410
Create v6 ParameterSentence components with Styled System #410
Conversation
Pending v6 Listbox update (see Faithlife#411).
I've updated |
I think that we can go ahead and get this PR merged first, then follow-up with any necessary changes to the v6 ParameterSelect once the Listbox changes are in. |
Sounds good! |
Final version from da75a5d.
Rolling along on #378 🚗
Just a draft at the moment.
ParameterSentence
andParameterInputBox
are ready, but working onParameterSelect
raised some questions aboutListbox
that need to be resolved first. I'm going to bring that up in a new issue (#411).In the meantime, though, one change in here that may seem unrelated at first glance is in
components/utils/filter-props.js
. I was about to build something similar while adaptingParameterInputBox
when I noticed this file and that itsfilterChildProps
function was very close to what I needed. I saw it wasn't being used anywhere in the project, so I took the liberty of adapting it to a slightly more general purpose, renaming it to justfilterProps
(though it can still be used for filtering child props specifically). Hope that's cool. 👍🏼