Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing properties to a few entries in the docs #305

Closed
wants to merge 2 commits into from

Conversation

object-Object
Copy link
Member

Adds the following missing properties:

  • Greater Sentinel: anchor
  • Charon: input, output
  • Consideration: input, output
  • Introspection: input, output
  • Retrospection: input, output

I generated the docs on my machine with these changes and everything seems to be working. I didn't build the mod because I don't have a dev environment set up, but I don't think these changes would break anything?

(I found these with HexBug's type scraper)

@object-Object
Copy link
Member Author

Also: Consideration, Introspection, Retrospection, and Novice's Gambit are all missing op_id, but I wasn't sure if adding that would break things, since the first three aren't in the registry and the last is actually Bookkeeper's Gambit.

@gamma-delta
Copy link
Collaborator

Intro/retro/consideration shouldn't have inputs and outputs, and you're right those four shouldn't have op-ids (for exactly that reason)

If you fix those up I'll merge it

@object-Object
Copy link
Member Author

Re intro/retro/consideration: several other patterns also don't have inputs or outputs, but they still have the input and output fields, they're just empty strings. For example: Summon Rain

@gamma-delta
Copy link
Collaborator

Yeah, but still, intro/retro are special-er than summon rain... they're not really actions, they're more like syntax if anything. And it seems strange to annotate bits of syntax as if they were functions.

@object-Object
Copy link
Member Author

Makes sense, I guess. Updated

@object-Object object-Object mentioned this pull request Jan 24, 2023
17 tasks
@object-Object
Copy link
Member Author

planning to fix this as part of the docgen pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants