lfvm: sha3 tests #839
Merged
lfvm: sha3 tests #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facuMH
force-pushed
the
facundo/lfvm-sha3-test
branch
from
a2e1aa6
to
f30400c
Compare
LuisPH3
approved these changes
Oct 4, 2024
LuisPH3
requested changes
Oct 7, 2024
1 task
facuMH
force-pushed
the
facundo/lfvm-sha3-test
branch
from
f30400c
to
9aeb9cc
Compare
LuisPH3
reviewed
Oct 7, 2024
facuMH
force-pushed
the
facundo/lfvm-sha3-test
branch
from
fbcd1ec
to
6226241
Compare
LuisPH3
previously approved these changes
Oct 7, 2024
HerbertJordan
previously approved these changes
Oct 8, 2024
facuMH
force-pushed
the
facundo/lfvm-sha3-test
branch
from
7a2830d
to
afaaceb
Compare
simonlechner
previously approved these changes
Oct 8, 2024
A solution could be to assign gas, size and offset for each test case, to accurately point into each violation: |
facuMH
force-pushed
the
facundo/lfvm-sha3-test
branch
from
afaaceb
to
526016e
Compare
Actually, even after the merge of #838, tests cases still work as inteded, so this PR is good to go =) |
LuisPH3
force-pushed
the
facundo/lfvm-sha3-test
branch
from
526016e
to
e9c7935
Compare
facuMH
force-pushed
the
facundo/lfvm-sha3-test
branch
from
e9c7935
to
6014ff1
Compare
LuisPH3
previously approved these changes
Oct 9, 2024
LuisPH3
force-pushed
the
facundo/lfvm-sha3-test
branch
from
6014ff1
to
b01a37e
Compare
LuisPH3
previously approved these changes
Oct 9, 2024
facuMH
force-pushed
the
facundo/lfvm-sha3-test
branch
2 times, most recently
from
abffa43
to
d44fe63
Compare
facuMH
force-pushed
the
facundo/lfvm-sha3-test
branch
from
d44fe63
to
36e624a
Compare
LuisPH3
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #751
Adds 2 tests, one checking out of gas scenarios, another checking the same hash produced regardless of using hash cache or not.