Comprehensive unit testing of LFVM operations

[HerbertJordan]

This task focuses on testing properties of VM instructions, in particular code in instructions.go and super_instructions.go

Common properties to opcodes are:

• minimum required version
• static mode violation
• dynamic cost computation, leading to out of gas or overflow
• context calls are issued.

Properties common to certain ops are:

• JUMPDEST check for any jump operation (except for JUMP_TO)
  • TestInstructions_JumpInstructionsCheckJUMPDEST
• EIP-2929 COLD/WARM dynamic cost introduced in Berlin
  • SLOAD,
  • SSTORE
  • *CALL,
  • BALANCE,
  • EXT*
  • SELFDESTRUCT
• Memory operations
  ...

[LuisPH3]

Attempt to refactor existing end-to-end test #753

[LuisPH3]

• minimum required version
• static mode violation
• dynamic cost
• context calls are issued.

[LuisPH3]

note: opSwap2_Swap1_Pop_Jump never checked for jumpdest and is never tested for it.

[facuMH]

After the merge of #837 #839 #841 #838 there should be still need to test specific branches of

• Calldataload
• opExp
• opExtcodehash
• opExtCodeCopy
• returndatacopy

[facuMH]

• opLog also needs a test for memory expansion

[LuisPH3]

Regarding context calls, It would be interesting not only to test that calls are issued, but that the arguments passed to external context calls are correct as well:

• AccessAccount
  • TestSelfDestruct_ExistingAccountToNewBeneficiary
• Balance
  • TestSelfDestruct_ExistingAccountToNewBeneficiary
• GetCodeSize LFVM: Add tests for code related context calls #858
• GetCode LFVM: Add tests for code related context calls #858
• GetCodeHash LFVM: extcodehash test #850
• AccountExists
  • TestSelfDestruct_ProperlyReportsNotEnoughGas
• AccessStorage LFVM: add test to validate storage runtime context calls arguments.  #861
• GetStorage LFVM: add test to validate storage runtime context calls arguments.  #861
• SetStorage LFVM: add test to validate storage runtime context calls arguments.  #861
• Call LFVM: remove gomock.any in genericcall tests #859
• EmitLog LFVM: Add test for log operation #856
• SelfDestruct
  • TestSelfDestruct_ExistingAccountToNewBeneficiary
• GetTransientStorage LFVM: Refactor test to validate transient storage run context calls.  #860
• SetTransientStorage LFVM: Refactor test to validate transient storage run context calls.  #860