Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LFVM: Add test for log operation #856

Merged
merged 3 commits into from
Oct 14, 2024
Merged

LFVM: Add test for log operation #856

merged 3 commits into from
Oct 14, 2024

Conversation

LuisPH3
Copy link
Contributor

@LuisPH3 LuisPH3 commented Oct 9, 2024

part of #751

Add tests for log operation. The test regarding minimum version is done in together with all operations introduced in different revisions.

facuMH
facuMH previously approved these changes Oct 9, 2024
HerbertJordan
HerbertJordan previously approved these changes Oct 9, 2024
go/interpreter/lfvm/instructions_test.go Outdated Show resolved Hide resolved
go/interpreter/lfvm/instructions_test.go Show resolved Hide resolved
new test covers error reporting, expansion errors are off-loaded to memory testing, new test tests arguments passed to emitLog and size cost
- test log topics order
- test mem copied
@LuisPH3 LuisPH3 merged commit 86b61f7 into main Oct 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants