LFVM: add test to bring converter coverage back to 100% #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HerbertJordan
approved these changes
Oct 9, 2024
facuMH
reviewed
Oct 14, 2024
LuisPH3
force-pushed
the
luis/coverage_converter
branch
from
011bca4
to
1ed32b9
Compare
facuMH
approved these changes
Oct 14, 2024
LuisPH3
force-pushed
the
luis/coverage_converter
branch
3 times, most recently
from
d77412d
to
27a1aec
Compare
LuisPH3
force-pushed
the
luis/coverage_converter
branch
from
27a1aec
to
2f37b14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #751
Refactor introduced a new branch, this pr adds a test for the situation where converter does not find any SI fit for the input and it falls-back to use normal LFVM instructions.