feat: implement fswap module's genesis and params #1339

170210 · 2024-04-19T05:42:56Z

Description

implement genesis related functions
implement params & swapped related functions
add genesis IT & UT tests
add fswap module into baseApp

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

I followed the contributing guidelines and code of conduct.
I have added a relevant changelog to CHANGELOG.md
I have added tests to cover my changes.
I have updated the documentation accordingly.
I have updated API documentation client/docs/swagger-ui/swagger.yaml

Signed-off-by: 170210 <[email protected]>

codecov · 2024-04-19T08:43:35Z

Codecov Report

Attention: Patch coverage is 78.40000% with 27 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (pjdp1@6afe633). Click here to learn what that means.

Additional details and impacted files

@@           Coverage Diff            @@
##             pjdp1    #1339   +/-   ##
========================================
  Coverage         ?   70.34%           
========================================
  Files            ?      657           
  Lines            ?    54977           
  Branches         ?        0           
========================================
  Hits             ?    38675           
  Misses           ?    14119           
  Partials         ?     2183

Files	Coverage Δ
simapp/app.go	`79.68% <100.00%> (ø)`
x/fswap/keeper/keeper.go	`77.77% <100.00%> (ø)`
x/fswap/types/genesis.go	`100.00% <100.00%> (ø)`
x/fswap/types/keys.go	`0.00% <ø> (ø)`
x/fswap/types/params.go	`75.00% <100.00%> (ø)`
x/fswap/simulation/genesis.go	`92.59% <92.59%> (ø)`
x/fswap/keeper/fswap.go	`73.33% <73.33%> (ø)`
x/fswap/keeper/genesis.go	`55.55% <55.55%> (ø)`
x/fswap/types/config.go	`0.00% <0.00%> (ø)`
x/fswap/types/fswap.go	`79.16% <79.16%> (ø)`
... and 1 more

Signed-off-by: 170210 <[email protected]>

CHANGELOG.md

x/fswap/types/params.go

x/fswap/keeper/genesis.go

Signed-off-by: 170210 <[email protected]>

x/fswap/types/genesis.go

Signed-off-by: 170210 <[email protected]>

0Tech

We should consider making the swappable amount as a parameter.

Signed-off-by: 170210 <[email protected]>

x/fswap/types/keys.go

x/fswap/keeper/fswap.go

Signed-off-by: 170210 <[email protected]>

x/fswap/types/genesis.go

This reverts commit e42e064.

Signed-off-by: 170210 <[email protected]>

x/fswap/types/errors.go

proto/lbm/fswap/v1/query.proto

x/fswap/types/keys.go

x/fswap/module_simulation.go

Signed-off-by: 170210 <[email protected]>

0Tech

LGTM

* feat: initialize fswap module (#1336) * feat: initial fswap module Signed-off-by: 170210 <[email protected]> * chore: correct dependencies Signed-off-by: 170210 <[email protected]> * chore: remove unuse files Signed-off-by: 170210 <[email protected]> * feat: add proto files Signed-off-by: 170210 <[email protected]> * chore: make proto-gen Signed-off-by: 170210 <[email protected]> * chore: fix compile error Signed-off-by: 170210 <[email protected]> * chore: add new field in params proto Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * feat: add query&tx commands of fswap module Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> * docs: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * docs: fix error docs Signed-off-by: 170210 <[email protected]> * fix: fix consensusversion Signed-off-by: 170210 <[email protected]> * fix: remove route,type&getSignBytes in msgs.go Signed-off-by: 170210 <[email protected]> * fix: update proto files Signed-off-by: 170210 <[email protected]> * fix: fix NewKeeper Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: implement fswap module's genesis and params (#1339) * feat: implement genesis related functions Signed-off-by: 170210 <[email protected]> * chore: use mockgen Signed-off-by: 170210 <[email protected]> * chore: add tests Signed-off-by: 170210 <[email protected]> * fix: add subspace in paramsKeeper Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix for test errors Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix appmodulebasic Signed-off-by: 170210 <[email protected]> * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * fix: use configuration instead of params Signed-off-by: 170210 <[email protected]> * chore: refactor new&default fswapped Signed-off-by: 170210 <[email protected]> * fix: add total_supply into genesisStatus & remove calculate logic Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix module_simulation Signed-off-by: 170210 <[email protected]> * fix: set swappableNewCoinDenom as params Signed-off-by: 170210 <[email protected]> * fix: change total_supply name to swappableNewCoinAmount Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: use io/collection to generate key Signed-off-by: 170210 <[email protected]> * Revert "fix: use io/collection to generate key" This reverts commit e42e064. * fix: change sdk.Coin to sdk.Int Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: remote unnecessary codes Signed-off-by: 170210 <[email protected]> * fix: add validate for swappable new coin Signed-off-by: 170210 <[email protected]> * fix: add randomizedGenState Signed-off-by: 170210 <[email protected]> * fix: fix error doc Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: change proto message fields' name Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: initialize fbridge module (#1340) * initialize fbridge module * add all proto files for fbridge * add missing proto files * initialize module structure * modify proto based on discussion * add codec * add CHANGELOG * modify UpdateRole feature * feat: fbridge transfer (#1347) * impl bridge transfer tx/query * add CLI * feat: save sequence for every bridge request (#1351) * feat: add SeqToBlocknum * add CHANGELOG * add query bound for SeqToBlocknums * feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (#1345) * refactor: fswap module's proto Signed-off-by: 170210 <[email protected]> * refactor: remove config&params and modify genesis Signed-off-by: 170210 <[email protected]> * refactor: use gov/proposal to change fswapInit Signed-off-by: 170210 <[email protected]> * chore: fix simulation Signed-off-by: 170210 <[email protected]> * chore: correct query cli Signed-off-by: 170210 <[email protected]> * chore: add query for test Signed-off-by: 170210 <[email protected]> * chore: lint fix * chore: fix for tx cli * chore: update proto * chore: update genesis logic * chore: add basic tx and queries * chore: rename fswap to swap * chore: change old/new to from/to * chore: clean-up * chore: clean errors and rename * chore: update proto * chore: clean unnecessary member variables * chore: update proto, introduce config, clean code * chore: remove redundant denom validation * chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2 * chore: apply feedbacks * chore: fix some * chore: fix for initGenesis * chore: apply feedbacks * chore: update changelog * chore: remove redundant logic * chore: update error doc * chore: update proto and logic to accept bank.Metadata * chore: add query to get all the swaps * chore: change swap_multiple to swap_rate * chore: disallow updating existing denom metadata with different values * chore: fix for calcSwap logic * chore: extract CalcSwap to function * chore: add missing query cmd * chore: fix for proposal cli * chore: fix for init timing * chore: fix query cli * chore: fix to prevent generating swap more than MaxSwaps * fix: add missing call validateBasic for proposal * fix: * chore: change error type for temporal test-pass * chore: fix for make-swap-proposal update * chore: fix to check swap count after increase in order not to make more than limit * chore: prevent any proposal with different denom * chore: change amount cap type * chore: fix codec-related parts * chore: minor change for convert to-coin-amount-cap --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: jaeseung.bae <[email protected]> --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: 170210 <[email protected]> Co-authored-by: Jayden Lee <[email protected]>

* feat: initialize fswap module (Finschia#1336) * feat: initial fswap module Signed-off-by: 170210 <[email protected]> * chore: correct dependencies Signed-off-by: 170210 <[email protected]> * chore: remove unuse files Signed-off-by: 170210 <[email protected]> * feat: add proto files Signed-off-by: 170210 <[email protected]> * chore: make proto-gen Signed-off-by: 170210 <[email protected]> * chore: fix compile error Signed-off-by: 170210 <[email protected]> * chore: add new field in params proto Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * feat: add query&tx commands of fswap module Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> * docs: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * docs: fix error docs Signed-off-by: 170210 <[email protected]> * fix: fix consensusversion Signed-off-by: 170210 <[email protected]> * fix: remove route,type&getSignBytes in msgs.go Signed-off-by: 170210 <[email protected]> * fix: update proto files Signed-off-by: 170210 <[email protected]> * fix: fix NewKeeper Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: implement fswap module's genesis and params (Finschia#1339) * feat: implement genesis related functions Signed-off-by: 170210 <[email protected]> * chore: use mockgen Signed-off-by: 170210 <[email protected]> * chore: add tests Signed-off-by: 170210 <[email protected]> * fix: add subspace in paramsKeeper Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix for test errors Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix appmodulebasic Signed-off-by: 170210 <[email protected]> * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * fix: use configuration instead of params Signed-off-by: 170210 <[email protected]> * chore: refactor new&default fswapped Signed-off-by: 170210 <[email protected]> * fix: add total_supply into genesisStatus & remove calculate logic Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix module_simulation Signed-off-by: 170210 <[email protected]> * fix: set swappableNewCoinDenom as params Signed-off-by: 170210 <[email protected]> * fix: change total_supply name to swappableNewCoinAmount Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: use io/collection to generate key Signed-off-by: 170210 <[email protected]> * Revert "fix: use io/collection to generate key" This reverts commit e42e064. * fix: change sdk.Coin to sdk.Int Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: remote unnecessary codes Signed-off-by: 170210 <[email protected]> * fix: add validate for swappable new coin Signed-off-by: 170210 <[email protected]> * fix: add randomizedGenState Signed-off-by: 170210 <[email protected]> * fix: fix error doc Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: change proto message fields' name Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: initialize fbridge module (Finschia#1340) * initialize fbridge module * add all proto files for fbridge * add missing proto files * initialize module structure * modify proto based on discussion * add codec * add CHANGELOG * modify UpdateRole feature * feat: fbridge transfer (Finschia#1347) * impl bridge transfer tx/query * add CLI * feat: save sequence for every bridge request (Finschia#1351) * feat: add SeqToBlocknum * add CHANGELOG * add query bound for SeqToBlocknums * feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (Finschia#1345) * refactor: fswap module's proto Signed-off-by: 170210 <[email protected]> * refactor: remove config&params and modify genesis Signed-off-by: 170210 <[email protected]> * refactor: use gov/proposal to change fswapInit Signed-off-by: 170210 <[email protected]> * chore: fix simulation Signed-off-by: 170210 <[email protected]> * chore: correct query cli Signed-off-by: 170210 <[email protected]> * chore: add query for test Signed-off-by: 170210 <[email protected]> * chore: lint fix * chore: fix for tx cli * chore: update proto * chore: update genesis logic * chore: add basic tx and queries * chore: rename fswap to swap * chore: change old/new to from/to * chore: clean-up * chore: clean errors and rename * chore: update proto * chore: clean unnecessary member variables * chore: update proto, introduce config, clean code * chore: remove redundant denom validation * chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2 * chore: apply feedbacks * chore: fix some * chore: fix for initGenesis * chore: apply feedbacks * chore: update changelog * chore: remove redundant logic * chore: update error doc * chore: update proto and logic to accept bank.Metadata * chore: add query to get all the swaps * chore: change swap_multiple to swap_rate * chore: disallow updating existing denom metadata with different values * chore: fix for calcSwap logic * chore: extract CalcSwap to function * chore: add missing query cmd * chore: fix for proposal cli * chore: fix for init timing * chore: fix query cli * chore: fix to prevent generating swap more than MaxSwaps * fix: add missing call validateBasic for proposal * fix: * chore: change error type for temporal test-pass * chore: fix for make-swap-proposal update * chore: fix to check swap count after increase in order not to make more than limit * chore: prevent any proposal with different denom * chore: change amount cap type * chore: fix codec-related parts * chore: minor change for convert to-coin-amount-cap --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: jaeseung.bae <[email protected]> --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: 170210 <[email protected]> Co-authored-by: Jayden Lee <[email protected]>

* feat: introduce new modules(fswap, fbridge) (#1352) * feat: initialize fswap module (#1336) * feat: initial fswap module Signed-off-by: 170210 <[email protected]> * chore: correct dependencies Signed-off-by: 170210 <[email protected]> * chore: remove unuse files Signed-off-by: 170210 <[email protected]> * feat: add proto files Signed-off-by: 170210 <[email protected]> * chore: make proto-gen Signed-off-by: 170210 <[email protected]> * chore: fix compile error Signed-off-by: 170210 <[email protected]> * chore: add new field in params proto Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * feat: add query&tx commands of fswap module Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> * docs: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * docs: fix error docs Signed-off-by: 170210 <[email protected]> * fix: fix consensusversion Signed-off-by: 170210 <[email protected]> * fix: remove route,type&getSignBytes in msgs.go Signed-off-by: 170210 <[email protected]> * fix: update proto files Signed-off-by: 170210 <[email protected]> * fix: fix NewKeeper Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: implement fswap module's genesis and params (#1339) * feat: implement genesis related functions Signed-off-by: 170210 <[email protected]> * chore: use mockgen Signed-off-by: 170210 <[email protected]> * chore: add tests Signed-off-by: 170210 <[email protected]> * fix: add subspace in paramsKeeper Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix for test errors Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix appmodulebasic Signed-off-by: 170210 <[email protected]> * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * fix: use configuration instead of params Signed-off-by: 170210 <[email protected]> * chore: refactor new&default fswapped Signed-off-by: 170210 <[email protected]> * fix: add total_supply into genesisStatus & remove calculate logic Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix module_simulation Signed-off-by: 170210 <[email protected]> * fix: set swappableNewCoinDenom as params Signed-off-by: 170210 <[email protected]> * fix: change total_supply name to swappableNewCoinAmount Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: use io/collection to generate key Signed-off-by: 170210 <[email protected]> * Revert "fix: use io/collection to generate key" This reverts commit e42e064. * fix: change sdk.Coin to sdk.Int Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: remote unnecessary codes Signed-off-by: 170210 <[email protected]> * fix: add validate for swappable new coin Signed-off-by: 170210 <[email protected]> * fix: add randomizedGenState Signed-off-by: 170210 <[email protected]> * fix: fix error doc Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: change proto message fields' name Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: initialize fbridge module (#1340) * initialize fbridge module * add all proto files for fbridge * add missing proto files * initialize module structure * modify proto based on discussion * add codec * add CHANGELOG * modify UpdateRole feature * feat: fbridge transfer (#1347) * impl bridge transfer tx/query * add CLI * feat: save sequence for every bridge request (#1351) * feat: add SeqToBlocknum * add CHANGELOG * add query bound for SeqToBlocknums * feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (#1345) * refactor: fswap module's proto Signed-off-by: 170210 <[email protected]> * refactor: remove config&params and modify genesis Signed-off-by: 170210 <[email protected]> * refactor: use gov/proposal to change fswapInit Signed-off-by: 170210 <[email protected]> * chore: fix simulation Signed-off-by: 170210 <[email protected]> * chore: correct query cli Signed-off-by: 170210 <[email protected]> * chore: add query for test Signed-off-by: 170210 <[email protected]> * chore: lint fix * chore: fix for tx cli * chore: update proto * chore: update genesis logic * chore: add basic tx and queries * chore: rename fswap to swap * chore: change old/new to from/to * chore: clean-up * chore: clean errors and rename * chore: update proto * chore: clean unnecessary member variables * chore: update proto, introduce config, clean code * chore: remove redundant denom validation * chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2 * chore: apply feedbacks * chore: fix some * chore: fix for initGenesis * chore: apply feedbacks * chore: update changelog * chore: remove redundant logic * chore: update error doc * chore: update proto and logic to accept bank.Metadata * chore: add query to get all the swaps * chore: change swap_multiple to swap_rate * chore: disallow updating existing denom metadata with different values * chore: fix for calcSwap logic * chore: extract CalcSwap to function * chore: add missing query cmd * chore: fix for proposal cli * chore: fix for init timing * chore: fix query cli * chore: fix to prevent generating swap more than MaxSwaps * fix: add missing call validateBasic for proposal * fix: * chore: change error type for temporal test-pass * chore: fix for make-swap-proposal update * chore: fix to check swap count after increase in order not to make more than limit * chore: prevent any proposal with different denom * chore: change amount cap type * chore: fix codec-related parts * chore: minor change for convert to-coin-amount-cap --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: jaeseung.bae <[email protected]> --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: 170210 <[email protected]> Co-authored-by: Jayden Lee <[email protected]> * chore: lint fix --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: 170210 <[email protected]> Co-authored-by: Jayden Lee <[email protected]>

170210 added 8 commits April 18, 2024 17:55

feat: implement genesis related functions

c5d92f9

Signed-off-by: 170210 <[email protected]>

chore: use mockgen

7063c9b

Signed-off-by: 170210 <[email protected]>

chore: add tests

27b9b2a

Signed-off-by: 170210 <[email protected]>

fix: add subspace in paramsKeeper

3afadd4

Signed-off-by: 170210 <[email protected]>

fix: fix lint

31d3829

Signed-off-by: 170210 <[email protected]>

fix: fix for test errors

f63ce4d

Signed-off-by: 170210 <[email protected]>

fix: fix lint

6d59aa8

Signed-off-by: 170210 <[email protected]>

fix: fix appmodulebasic

96da1de

Signed-off-by: 170210 <[email protected]>

chore: update CHANGLOG.md

065f4f2

Signed-off-by: 170210 <[email protected]>

170210 self-assigned this Apr 19, 2024

170210 marked this pull request as ready for review April 19, 2024 08:46

170210 requested review from tkxkd0159, zemyblue, 0Tech and jaeseung-bae as code owners April 19, 2024 08:46

0Tech reviewed Apr 22, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

x/fswap/types/params.go Outdated Show resolved Hide resolved

x/fswap/keeper/genesis.go Outdated Show resolved Hide resolved

170210 changed the title ~~feat: implement genesis and params~~ feat: implement genesis and params of fswap module Apr 23, 2024

170210 changed the title ~~feat: implement genesis and params of fswap module~~ feat: implement fswap module's genesis and params Apr 23, 2024

fix: use configuration instead of params

0423ac7

Signed-off-by: 170210 <[email protected]>

0Tech reviewed Apr 23, 2024

View reviewed changes

x/fswap/types/genesis.go Outdated Show resolved Hide resolved

170210 added 4 commits April 23, 2024 18:33

chore: refactor new&default fswapped

8fcbab8

Signed-off-by: 170210 <[email protected]>

fix: add total_supply into genesisStatus & remove calculate logic

c91259f

Signed-off-by: 170210 <[email protected]>

fix: fix lint

d6f2ce9

Signed-off-by: 170210 <[email protected]>

fix: fix module_simulation

d0f4841

Signed-off-by: 170210 <[email protected]>

0Tech reviewed Apr 24, 2024

View reviewed changes

fix: set swappableNewCoinDenom as params

3cd7acb

Signed-off-by: 170210 <[email protected]>

170210 requested a review from 0Tech April 24, 2024 04:26

jaeseung-bae reviewed Apr 24, 2024

View reviewed changes

x/fswap/types/keys.go Outdated Show resolved Hide resolved

jaeseung-bae reviewed Apr 24, 2024

View reviewed changes

x/fswap/keeper/fswap.go Outdated Show resolved Hide resolved

fix: change total_supply name to swappableNewCoinAmount

c2a9b61

Signed-off-by: 170210 <[email protected]>

170210 force-pushed the feat/fswap_genesis branch from 22a7efe to c2a9b61 Compare April 24, 2024 05:10

170210 added 2 commits April 24, 2024 14:16

fix: fix lint

f0be4eb

Signed-off-by: 170210 <[email protected]>

fix: use io/collection to generate key

e42e064

Signed-off-by: 170210 <[email protected]>

0Tech reviewed Apr 24, 2024

View reviewed changes

x/fswap/types/genesis.go Show resolved Hide resolved

170210 added 3 commits April 24, 2024 14:45

Revert "fix: use io/collection to generate key"

09562a4

This reverts commit e42e064.

fix: change sdk.Coin to sdk.Int

688d489

Signed-off-by: 170210 <[email protected]>

fix: fix lint

a9ca68f

Signed-off-by: 170210 <[email protected]>

170210 requested review from 0Tech and jaeseung-bae April 24, 2024 07:22

jaeseung-bae reviewed Apr 24, 2024

View reviewed changes

x/fswap/types/errors.go Outdated Show resolved Hide resolved

jaeseung-bae reviewed Apr 24, 2024

View reviewed changes

proto/lbm/fswap/v1/query.proto Outdated Show resolved Hide resolved

0Tech reviewed Apr 24, 2024

View reviewed changes

x/fswap/types/keys.go Outdated Show resolved Hide resolved

x/fswap/module_simulation.go Outdated Show resolved Hide resolved

170210 added 6 commits April 24, 2024 17:51

fix: remote unnecessary codes

722e95b

Signed-off-by: 170210 <[email protected]>

fix: add validate for swappable new coin

160f953

Signed-off-by: 170210 <[email protected]>

fix: add randomizedGenState

eff7746

Signed-off-by: 170210 <[email protected]>

fix: fix error doc

bd076f9

Signed-off-by: 170210 <[email protected]>

fix: fix lint

61f09fa

Signed-off-by: 170210 <[email protected]>

fix: change proto message fields' name

9d583c3

Signed-off-by: 170210 <[email protected]>

170210 requested review from 0Tech and jaeseung-bae April 24, 2024 11:33

jaeseung-bae approved these changes Apr 25, 2024

View reviewed changes

0Tech approved these changes Apr 25, 2024

View reviewed changes

170210 merged commit 52a3f83 into Finschia:pjdp1 Apr 25, 2024
33 checks passed

zemyblue mentioned this pull request May 27, 2024

Release finschia-sdk v0.49.0 #1404

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement fswap module's genesis and params #1339

feat: implement fswap module's genesis and params #1339

170210 commented Apr 19, 2024 •

edited

Loading

codecov bot commented Apr 19, 2024 •

edited

Loading

0Tech left a comment

0Tech left a comment

feat: implement fswap module's genesis and params #1339

feat: implement fswap module's genesis and params #1339

Conversation

170210 commented Apr 19, 2024 • edited Loading

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov bot commented Apr 19, 2024 • edited Loading

Codecov Report

0Tech left a comment

Choose a reason for hiding this comment

0Tech left a comment

Choose a reason for hiding this comment

170210 commented Apr 19, 2024 •

edited

Loading

codecov bot commented Apr 19, 2024 •

edited

Loading