Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce new modules(fswap, fbridge) (backport #1352) #1357

Merged

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented May 7, 2024

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

jaeseung-bae and others added 2 commits May 7, 2024 16:11
* feat: initialize fswap module (Finschia#1336)

* feat: initial fswap module

Signed-off-by: 170210 <[email protected]>

* chore: correct dependencies

Signed-off-by: 170210 <[email protected]>

* chore: remove unuse files

Signed-off-by: 170210 <[email protected]>

* feat: add proto files

Signed-off-by: 170210 <[email protected]>

* chore: make proto-gen

Signed-off-by: 170210 <[email protected]>

* chore: fix compile error

Signed-off-by: 170210 <[email protected]>

* chore: add new field in params proto

Signed-off-by: 170210 <[email protected]>

* fix: fix lint

Signed-off-by: 170210 <[email protected]>

* feat: add query&tx commands of fswap module

Signed-off-by: 170210 <[email protected]>

* fix: fix for comment

Signed-off-by: 170210 <[email protected]>

* docs: update CHANGLOG.md

Signed-off-by: 170210 <[email protected]>

* docs: fix error docs

Signed-off-by: 170210 <[email protected]>

* fix: fix consensusversion

Signed-off-by: 170210 <[email protected]>

* fix: remove route,type&getSignBytes in msgs.go

Signed-off-by: 170210 <[email protected]>

* fix: update proto files

Signed-off-by: 170210 <[email protected]>

* fix: fix NewKeeper

Signed-off-by: 170210 <[email protected]>

* fix: fix for comment

Signed-off-by: 170210 <[email protected]>

---------

Signed-off-by: 170210 <[email protected]>

* feat: implement fswap module's genesis and params (Finschia#1339)

* feat: implement genesis related functions

Signed-off-by: 170210 <[email protected]>

* chore: use mockgen

Signed-off-by: 170210 <[email protected]>

* chore: add tests

Signed-off-by: 170210 <[email protected]>

* fix: add subspace in paramsKeeper

Signed-off-by: 170210 <[email protected]>

* fix: fix lint

Signed-off-by: 170210 <[email protected]>

* fix: fix for test errors

Signed-off-by: 170210 <[email protected]>

* fix: fix lint

Signed-off-by: 170210 <[email protected]>

* fix: fix appmodulebasic

Signed-off-by: 170210 <[email protected]>

* chore: update CHANGLOG.md

Signed-off-by: 170210 <[email protected]>

* fix: use configuration instead of params

Signed-off-by: 170210 <[email protected]>

* chore: refactor new&default fswapped

Signed-off-by: 170210 <[email protected]>

* fix: add total_supply into genesisStatus & remove calculate logic

Signed-off-by: 170210 <[email protected]>

* fix: fix lint

Signed-off-by: 170210 <[email protected]>

* fix: fix module_simulation

Signed-off-by: 170210 <[email protected]>

* fix: set swappableNewCoinDenom as params

Signed-off-by: 170210 <[email protected]>

* fix: change total_supply name to swappableNewCoinAmount

Signed-off-by: 170210 <[email protected]>

* fix: fix lint

Signed-off-by: 170210 <[email protected]>

* fix: use io/collection to generate key

Signed-off-by: 170210 <[email protected]>

* Revert "fix: use io/collection to generate key"

This reverts commit e42e064.

* fix: change sdk.Coin to sdk.Int

Signed-off-by: 170210 <[email protected]>

* fix: fix lint

Signed-off-by: 170210 <[email protected]>

* fix: remote unnecessary codes

Signed-off-by: 170210 <[email protected]>

* fix: add validate for swappable new coin

Signed-off-by: 170210 <[email protected]>

* fix: add randomizedGenState

Signed-off-by: 170210 <[email protected]>

* fix: fix error doc

Signed-off-by: 170210 <[email protected]>

* fix: fix lint

Signed-off-by: 170210 <[email protected]>

* fix: change proto message fields' name

Signed-off-by: 170210 <[email protected]>

---------

Signed-off-by: 170210 <[email protected]>

* feat: initialize fbridge module (Finschia#1340)

* initialize fbridge module

* add all proto files for fbridge

* add missing proto files

* initialize module structure

* modify proto based on discussion

* add codec

* add CHANGELOG

* modify UpdateRole feature

* feat: fbridge transfer (Finschia#1347)

* impl bridge transfer tx/query

* add CLI

* feat: save sequence for every bridge request (Finschia#1351)

* feat: add SeqToBlocknum

* add CHANGELOG

* add query bound for SeqToBlocknums

* feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (Finschia#1345)

* refactor: fswap module's proto

Signed-off-by: 170210 <[email protected]>

* refactor: remove config&params and modify genesis

Signed-off-by: 170210 <[email protected]>

* refactor: use gov/proposal to change fswapInit

Signed-off-by: 170210 <[email protected]>

* chore: fix simulation

Signed-off-by: 170210 <[email protected]>

* chore: correct query cli

Signed-off-by: 170210 <[email protected]>

* chore: add query for test

Signed-off-by: 170210 <[email protected]>

* chore: lint fix

* chore: fix for tx cli

* chore: update proto

* chore: update genesis logic

* chore: add basic tx and queries

* chore: rename fswap to swap

* chore: change old/new to from/to

* chore: clean-up

* chore: clean errors and rename

* chore: update proto

* chore: clean unnecessary member variables

* chore: update proto, introduce config, clean code

* chore: remove redundant denom validation

* chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2

* chore: apply feedbacks

* chore: fix some

* chore: fix for initGenesis

* chore: apply feedbacks

* chore: update changelog

* chore: remove redundant logic

* chore: update error doc

* chore: update proto and logic to accept bank.Metadata

* chore: add query to get all the swaps

* chore: change swap_multiple to swap_rate

* chore: disallow updating existing denom metadata with different values

* chore: fix for calcSwap logic

* chore: extract CalcSwap to function

* chore: add missing query cmd

* chore: fix for proposal cli

* chore: fix for init timing

* chore: fix query cli

* chore: fix to prevent generating swap more than MaxSwaps

* fix: add missing call validateBasic for proposal

* fix:

* chore: change error type for temporal test-pass

* chore: fix for make-swap-proposal update

* chore: fix to check swap count after increase in order not to make more than limit

* chore: prevent any proposal with different denom

* chore: change amount cap type

* chore: fix codec-related parts

* chore: minor change for convert to-coin-amount-cap

---------

Signed-off-by: 170210 <[email protected]>
Co-authored-by: jaeseung.bae <[email protected]>

---------

Signed-off-by: 170210 <[email protected]>
Co-authored-by: 170210 <[email protected]>
Co-authored-by: Jayden Lee <[email protected]>
@jaeseung-bae jaeseung-bae marked this pull request as ready for review May 7, 2024 07:25
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 33.58876% with 520 lines in your changes are missing coverage. Please review.

Project coverage is 69.33%. Comparing base (0dd215b) to head (6c5104c).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.49.x    #1357      +/-   ##
===================================================
- Coverage            69.75%   69.33%   -0.42%     
===================================================
  Files                  646      666      +20     
  Lines                67589    68371     +782     
===================================================
+ Hits                 47144    47406     +262     
- Misses               18255    18718     +463     
- Partials              2190     2247      +57     
Files Coverage Δ
simapp/app.go 82.28% <100.00%> (+0.71%) ⬆️
x/fswap/keeper/calc.go 100.00% <100.00%> (ø)
x/fswap/keeper/keys.go 100.00% <100.00%> (ø)
x/fswap/handler.go 77.77% <77.77%> (ø)
x/fswap/types/config.go 0.00% <0.00%> (ø)
x/fbridge/keeper/keeper.go 52.94% <52.94%> (ø)
x/fswap/types/codec.go 40.00% <40.00%> (ø)
x/fswap/module_simulation.go 7.14% <7.14%> (ø)
x/fswap/keeper/msg_server.go 55.88% <55.88%> (ø)
x/fswap/types/genesis.go 32.00% <32.00%> (ø)
... and 11 more

@jaeseung-bae jaeseung-bae requested a review from 170210 May 7, 2024 07:33
@jaeseung-bae jaeseung-bae self-assigned this May 7, 2024
@jaeseung-bae jaeseung-bae merged commit 98da17d into Finschia:release/v0.49.x May 7, 2024
30 of 31 checks passed
@jaeseung-bae jaeseung-bae deleted the feat/fswap-fbridge branch May 7, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants