-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add validation & unit tests in fswap module #1382
Conversation
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
Is it necessary to add the following validate in validateBasic:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1382 +/- ##
==========================================
+ Coverage 69.58% 69.68% +0.10%
==========================================
Files 668 668
Lines 56231 56242 +11
==========================================
+ Hits 39126 39194 +68
+ Misses 14834 14775 -59
- Partials 2271 2273 +2
|
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check failed test in CI?
Signed-off-by: 170210 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding unvalidated case unittest for genesis.go?
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
* chore: add logic validation & tests Signed-off-by: 170210 <[email protected]> * test: add genesisState tests Signed-off-by: 170210 <[email protected]> * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * chore: fix lint Signed-off-by: 170210 <[email protected]> * chore: add newKeeper test Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> * fix: fix test Signed-off-by: 170210 <[email protected]> * fix: fix for comments Signed-off-by: 170210 <[email protected]> * fix: fix failed tests Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> * fix: remove unused keeper in appmodule Signed-off-by: 170210 <[email protected]> * fix: fix for merge (FSwapQueryTestSuite Setup up) Signed-off-by: 170210 <[email protected]> * fix: fix for codecov Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> (cherry picked from commit dab544e)
* chore: add logic validation & tests Signed-off-by: 170210 <[email protected]> * test: add genesisState tests Signed-off-by: 170210 <[email protected]> * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * chore: fix lint Signed-off-by: 170210 <[email protected]> * chore: add newKeeper test Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> * fix: fix test Signed-off-by: 170210 <[email protected]> * fix: fix for comments Signed-off-by: 170210 <[email protected]> * fix: fix failed tests Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> * fix: remove unused keeper in appmodule Signed-off-by: 170210 <[email protected]> * fix: fix for merge (FSwapQueryTestSuite Setup up) Signed-off-by: 170210 <[email protected]> * fix: fix for codecov Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> (cherry picked from commit dab544e) Co-authored-by: 170210 <[email protected]>
Description
closes: #XXXX
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml