test: add validation & unit tests in fswap module

CHANGELOG.md

@@ -62,6 +62,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 * (x/fbridge) [\#1366](https://github.com/Finschia/finschia-sdk/pull/1366) Set target denom as module parameters
 * (x/fbridge) [\#1369](https://github.com/Finschia/finschia-sdk/pull/1369) Add the event of `SetBridgeStatus`
 * (x/fswap) [\#1372](https://github.com/Finschia/finschia-sdk/pull/1372) support message based proposals
+* (x/fswap) [\#1382](https://github.com/Finschia/finschia-sdk/pull/1382) add validation & unit tests in fswap module 
 
 ### Bug Fixes
 * chore(deps) [\#1141](https://github.com/Finschia/finschia-sdk/pull/1141) Bump github.com/cosmos/ledger-cosmos-go from 0.12.2 to 0.13.2 to fix ledger signing issue

Makefile

@@ -144,7 +144,7 @@ mocks: $(MOCKS_DIR)
 	mockgen -package mocks -destination tests/mocks/grpc_server.go github.com/gogo/protobuf/grpc Server
 	mockgen -package mocks -destination tests/mocks/tendermint_tendermint_libs_log_DB.go github.com/tendermint/tendermint/libs/log Logger
 	mockgen -source=x/stakingplus/expected_keepers.go -package testutil -destination x/stakingplus/testutil/expected_keepers_mocks.go
-	mockgen -source=x/fswap/types/expected_keepers.go -package testutil -destination x/fswap/testutil/expected_keepers_mocks.go
+	mockgen -source=x/fswap/keeper/expected_keepers.go -package testutil -destination x/fswap/testutil/expected_keepers_mocks.go
 	mockgen -source=x/fbridge/types/expected_keepers.go -package testutil -destination x/fbridge/testutil/expected_keepers_mocks.go
 .PHONY: mocks
 

simapp/app.go

@@ -342,7 +342,7 @@ func NewSimApp(
 	app.AuthzKeeper = authzkeeper.NewKeeper(keys[authzkeeper.StoreKey], appCodec, app.BaseApp.MsgServiceRouter())
 
 	fswapConfig := fswaptypes.DefaultConfig()
-	app.FswapKeeper = fswapkeeper.NewKeeper(appCodec, keys[fswaptypes.StoreKey], fswapConfig, fswaptypes.DefaultAuthority().String(), app.BankKeeper)
+	app.FswapKeeper = fswapkeeper.NewKeeper(appCodec, keys[fswaptypes.StoreKey], fswapConfig, fswaptypes.DefaultAuthority().String(), app.AccountKeeper, app.BankKeeper)
 
 	// register the proposal types
 	govRouter := govtypes.NewRouter()
@@ -403,7 +403,7 @@ func NewSimApp(
 		tokenmodule.NewAppModule(appCodec, app.TokenKeeper),
 		collectionmodule.NewAppModule(appCodec, app.CollectionKeeper),
 		authzmodule.NewAppModule(appCodec, app.AuthzKeeper, app.AccountKeeper, app.BankKeeper, app.interfaceRegistry),
-		fswap.NewAppModule(appCodec, app.FswapKeeper, app.BankKeeper),
+		fswap.NewAppModule(appCodec, app.FswapKeeper, app.AccountKeeper, app.BankKeeper),
 		fbridgemodule.NewAppModule(appCodec, app.FbridgeKeeper),
 	)
 

x/fswap/keeper/expected_keepers.go

@@ -5,15 +5,16 @@ import (
 	banktypes "github.com/Finschia/finschia-sdk/x/bank/types"
 )
 
-type (
-	BankKeeper interface {
-		GetBalance(ctx sdk.Context, addr sdk.AccAddress, denom string) sdk.Coin
-		SendCoinsFromModuleToAccount(ctx sdk.Context, senderModule string, recipientAddr sdk.AccAddress, amt sdk.Coins) error
-		SendCoinsFromAccountToModule(ctx sdk.Context, senderAddr sdk.AccAddress, recipientModule string, amt sdk.Coins) error
-		IsSendEnabledCoins(ctx sdk.Context, coins ...sdk.Coin) error
-		GetDenomMetaData(ctx sdk.Context, denom string) (banktypes.Metadata, bool)
-		SetDenomMetaData(ctx sdk.Context, denomMetaData banktypes.Metadata)
-		MintCoins(ctx sdk.Context, moduleName string, amt sdk.Coins) error
-		BurnCoins(ctx sdk.Context, moduleName string, amt sdk.Coins) error
-	}
-)
+type AccountKeeper interface {
+	GetModuleAddress(moduleName string) sdk.AccAddress
+}
+type BankKeeper interface {
+	GetBalance(ctx sdk.Context, addr sdk.AccAddress, denom string) sdk.Coin
+	SendCoinsFromModuleToAccount(ctx sdk.Context, senderModule string, recipientAddr sdk.AccAddress, amt sdk.Coins) error
+	SendCoinsFromAccountToModule(ctx sdk.Context, senderAddr sdk.AccAddress, recipientModule string, amt sdk.Coins) error
+	IsSendEnabledCoins(ctx sdk.Context, coins ...sdk.Coin) error
+	GetDenomMetaData(ctx sdk.Context, denom string) (banktypes.Metadata, bool)
+	SetDenomMetaData(ctx sdk.Context, denomMetaData banktypes.Metadata)
+	MintCoins(ctx sdk.Context, moduleName string, amt sdk.Coins) error
+	BurnCoins(ctx sdk.Context, moduleName string, amt sdk.Coins) error
+}

x/fswap/keeper/genesis_test.go

@@ -3,19 +3,45 @@ package keeper_test
 import (
 	"fmt"
 
+	sdk "github.com/Finschia/finschia-sdk/types"
 	"github.com/Finschia/finschia-sdk/x/fswap/types"
 )
 
 func (s *KeeperTestSuite) TestInitAndExportGenesis() {
 	ctx, _ := s.ctx.CacheContext()
-	defaultGenesis := types.DefaultGenesis()
-	err := s.keeper.InitGenesis(ctx, defaultGenesis)
+	testSwapRate, _ := sdk.NewDecFromStr("1234567890")
+	testGenesis := &types.GenesisState{
+		Swaps: []types.Swap{
+			{
+				FromDenom:           "aaa",
+				ToDenom:             "bbb",
+				AmountCapForToDenom: sdk.NewInt(1234567890000),
+				SwapRate:            testSwapRate,
+			},
+		},
+		SwapStats: types.SwapStats{
+			SwapCount: 1,
+		},
+		Swappeds: []types.Swapped{
+			{
+				FromCoinAmount: sdk.Coin{
+					Denom:  "aaa",
+					Amount: sdk.ZeroInt(),
+				},
+				ToCoinAmount: sdk.Coin{
+					Denom:  "bbb",
+					Amount: sdk.ZeroInt(),
+				},
+			},
+		},
+	}
+	err := s.keeper.InitGenesis(ctx, testGenesis)
 	s.Require().NoError(err)
 
 	exportGenesis := s.keeper.ExportGenesis(ctx)
 	fmt.Println(len(exportGenesis.GetSwaps()))
-	s.Require().Equal(defaultGenesis, exportGenesis)
-	s.Require().Equal(defaultGenesis.GetSwaps(), exportGenesis.GetSwaps())
-	s.Require().Equal(defaultGenesis.GetSwapStats(), exportGenesis.GetSwapStats())
-	s.Require().Equal(defaultGenesis.GetSwappeds(), exportGenesis.GetSwappeds())
+	s.Require().Equal(testGenesis, exportGenesis)
+	s.Require().Equal(testGenesis.GetSwaps(), exportGenesis.GetSwaps())
+	s.Require().Equal(testGenesis.GetSwapStats(), exportGenesis.GetSwapStats())
+	s.Require().Equal(testGenesis.GetSwappeds(), exportGenesis.GetSwappeds())
 }

x/fswap/keeper/keeper.go

@@ -15,18 +15,23 @@ import (
 )
 
 type Keeper struct {
-	cdc       codec.BinaryCodec
-	storeKey  storetypes.StoreKey
-	config    types.Config
-	authority string
+	cdc        codec.BinaryCodec
+	storeKey   storetypes.StoreKey
+	config     types.Config
+	authority  string
+	authkeeper AccountKeeper
 	BankKeeper
 }
 
-func NewKeeper(cdc codec.BinaryCodec, storeKey storetypes.StoreKey, config types.Config, authority string, bk BankKeeper) Keeper {
+func NewKeeper(cdc codec.BinaryCodec, storeKey storetypes.StoreKey, config types.Config, authority string, ak AccountKeeper, bk BankKeeper) Keeper {
 	if _, err := sdk.AccAddressFromBech32(authority); err != nil {
 		panic("authority is not a valid acc address")
 	}
 
+	if addr := ak.GetModuleAddress(types.ModuleName); addr == nil {
+		panic("fswap module account has not been set")
+	}
+
 	found := false
 	for _, addr := range types.AuthorityCandidates() {
 		if authority == addr.String() {
@@ -44,6 +49,7 @@ func NewKeeper(cdc codec.BinaryCodec, storeKey storetypes.StoreKey, config types
 		storeKey,
 		config,
 		authority,
+		ak,
 		bk,
 	}
 }
@@ -125,6 +131,10 @@ func (k Keeper) SetSwap(ctx sdk.Context, swap types.Swap, toDenomMetadata bank.M
 		return types.ErrCanNotHaveMoreSwap.Wrapf("cannot make more swaps, max swaps is %d", k.config.MaxSwaps)
 	}
 
+	if _, ok := k.GetDenomMetaData(ctx, swap.FromDenom); !ok {
+		return sdkerrors.ErrInvalidRequest.Wrap("fromDenom should be existed in chain")
+	}
+
 	if isNewSwap {
 		swapped := types.Swapped{
 			FromCoinAmount: sdk.Coin{

x/fswap/keeper/keeper_test.go

@@ -4,6 +4,8 @@ import (
 	"context"
 	"testing"
 
+	"github.com/golang/mock/gomock"
+	"github.com/stretchr/testify/require"
 	"github.com/stretchr/testify/suite"
 	abci "github.com/tendermint/tendermint/abci/types"
 	tmproto "github.com/tendermint/tendermint/proto/tendermint/types"
@@ -13,9 +15,13 @@ import (
 	"github.com/Finschia/finschia-sdk/testutil/testdata"
 	sdk "github.com/Finschia/finschia-sdk/types"
 	sdkerrors "github.com/Finschia/finschia-sdk/types/errors"
+	authtypes "github.com/Finschia/finschia-sdk/x/auth/types"
 	bank "github.com/Finschia/finschia-sdk/x/bank/types"
+	"github.com/Finschia/finschia-sdk/x/foundation"
 	"github.com/Finschia/finschia-sdk/x/fswap/keeper"
+	"github.com/Finschia/finschia-sdk/x/fswap/testutil"
 	"github.com/Finschia/finschia-sdk/x/fswap/types"
+	govtypes "github.com/Finschia/finschia-sdk/x/gov/types"
 	minttypes "github.com/Finschia/finschia-sdk/x/mint/types"
 )
 
@@ -83,8 +89,8 @@ func (s *KeeperTestSuite) SetupTest() {
 		DenomUnits: []*bank.DenomUnit{
 			{Denom: s.swap.ToDenom, Exponent: 0},
 		},
-		Base:    "dummy",
-		Display: "dummycoin",
+		Base:    "todenom",
+		Display: "todenomcoin",
 		Name:    "DUMMY",
 		Symbol:  "DUM",
 	}
@@ -114,6 +120,56 @@ func TestKeeperTestSuite(t *testing.T) {
 	suite.Run(t, &KeeperTestSuite{})
 }
 
+func TestNewKeeper(t *testing.T) {
+	app := simapp.Setup(false)
+
+	ctrl := gomock.NewController(t)
+	defer ctrl.Finish()
+	authKeeper := testutil.NewMockAccountKeeper(ctrl)
+	testCases := map[string]struct {
+		malleate func()
+		isPanic  bool
+	}{
+		"fswap module account has not been set": {
+			malleate: func() {
+				authKeeper.EXPECT().GetModuleAddress(types.ModuleName).Return(nil).Times(1)
+				keeper.NewKeeper(app.AppCodec(), sdk.NewKVStoreKey(types.StoreKey), types.DefaultConfig(), types.DefaultAuthority().String(), authKeeper, app.BankKeeper)
+			},
+			isPanic: true,
+		},
+		"fswap authority must be the gov or foundation module account": {
+			malleate: func() {
+				authKeeper.EXPECT().GetModuleAddress(types.ModuleName).Return(authtypes.NewModuleAddress(types.ModuleName)).Times(1)
+				keeper.NewKeeper(app.AppCodec(), sdk.NewKVStoreKey(types.StoreKey), types.DefaultConfig(), authtypes.NewModuleAddress("invalid").String(), authKeeper, app.BankKeeper)
+			},
+			isPanic: true,
+		},
+		"success - gov authority": {
+			malleate: func() {
+				authKeeper.EXPECT().GetModuleAddress(types.ModuleName).Return(authtypes.NewModuleAddress(types.ModuleName)).Times(1)
+				keeper.NewKeeper(app.AppCodec(), sdk.NewKVStoreKey(types.StoreKey), types.DefaultConfig(), authtypes.NewModuleAddress(govtypes.ModuleName).String(), authKeeper, app.BankKeeper)
+			},
+			isPanic: false,
+		},
+		"success - foundation authority": {
+			malleate: func() {
+				authKeeper.EXPECT().GetModuleAddress(types.ModuleName).Return(authtypes.NewModuleAddress(types.ModuleName)).Times(1)
+				keeper.NewKeeper(app.AppCodec(), sdk.NewKVStoreKey(types.StoreKey), types.DefaultConfig(), authtypes.NewModuleAddress(foundation.ModuleName).String(), authKeeper, app.BankKeeper)
+			},
+			isPanic: false,
+		},
+	}
+	for name, tc := range testCases {
+		t.Run(name, func(t *testing.T) {
+			if tc.isPanic {
+				require.Panics(t, tc.malleate)
+			} else {
+				tc.malleate()
+			}
+		})
+	}
+}
+
 func (s *KeeperTestSuite) TestSwap() {
 	swap2ExpectedAmount, ok := sdk.NewIntFromString("296159312000000")
 	s.Require().True(ok)
@@ -190,30 +246,38 @@ func (s *KeeperTestSuite) TestSwap() {
 }
 
 func (s *KeeperTestSuite) TestSetSwap() {
+	ctrl := gomock.NewController(s.T())
+	defer ctrl.Finish()
+	bankKeeper := testutil.NewMockBankKeeper(ctrl)
+
 	testCases := map[string]struct {
-		swap             types.Swap
-		toDenomMeta      bank.Metadata
-		existingMetadata bool
-		expectedError    error
-		expectedEvents   sdk.Events
+		swap           types.Swap
+		toDenomMeta    bank.Metadata
+		malleate       func()
+		expectedError  error
+		expectedEvents sdk.Events
 	}{
 		"valid": {
 			types.Swap{
-				FromDenom:           "fromD",
-				ToDenom:             "toD",
+				FromDenom:           "fromdenom",
+				ToDenom:             "todenom",
 				AmountCapForToDenom: sdk.OneInt(),
 				SwapRate:            sdk.OneDec(),
 			},
 			s.toDenomMetadata,
-			false,
+			func() {
+				bankKeeper.EXPECT().GetDenomMetaData(gomock.Any(), "fromdenom").Return(bank.Metadata{}, true).Times(1)
+				bankKeeper.EXPECT().GetDenomMetaData(gomock.Any(), "todenom").Return(bank.Metadata{}, false).Times(1)
+				bankKeeper.EXPECT().SetDenomMetaData(gomock.Any(), s.toDenomMetadata).Times(1)
+			},
 			nil,
 			sdk.Events{
 				sdk.Event{
 					Type: "lbm.fswap.v1.EventSetSwap",
 					Attributes: []abci.EventAttribute{
 						{
 							Key:   []byte("swap"),
-							Value: []uint8{0x7b, 0x22, 0x66, 0x72, 0x6f, 0x6d, 0x5f, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x22, 0x3a, 0x22, 0x66, 0x72, 0x6f, 0x6d, 0x44, 0x22, 0x2c, 0x22, 0x74, 0x6f, 0x5f, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x22, 0x3a, 0x22, 0x74, 0x6f, 0x44, 0x22, 0x2c, 0x22, 0x61, 0x6d, 0x6f, 0x75, 0x6e, 0x74, 0x5f, 0x63, 0x61, 0x70, 0x5f, 0x66, 0x6f, 0x72, 0x5f, 0x74, 0x6f, 0x5f, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x22, 0x3a, 0x22, 0x31, 0x22, 0x2c, 0x22, 0x73, 0x77, 0x61, 0x70, 0x5f, 0x72, 0x61, 0x74, 0x65, 0x22, 0x3a, 0x22, 0x31, 0x2e, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x22, 0x7d},
+							Value: []uint8{0x7b, 0x22, 0x66, 0x72, 0x6f, 0x6d, 0x5f, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x22, 0x3a, 0x22, 0x66, 0x72, 0x6f, 0x6d, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x22, 0x2c, 0x22, 0x74, 0x6f, 0x5f, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x22, 0x3a, 0x22, 0x74, 0x6f, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x22, 0x2c, 0x22, 0x61, 0x6d, 0x6f, 0x75, 0x6e, 0x74, 0x5f, 0x63, 0x61, 0x70, 0x5f, 0x66, 0x6f, 0x72, 0x5f, 0x74, 0x6f, 0x5f, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x22, 0x3a, 0x22, 0x31, 0x22, 0x2c, 0x22, 0x73, 0x77, 0x61, 0x70, 0x5f, 0x72, 0x61, 0x74, 0x65, 0x22, 0x3a, 0x22, 0x31, 0x2e, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x22, 0x7d},
 							Index: false,
 						},
 					},
@@ -223,17 +287,57 @@ func (s *KeeperTestSuite) TestSetSwap() {
 					Attributes: []abci.EventAttribute{
 						{
 							Key:   []byte("metadata"),
-							Value: []uint8{0x7b, 0x22, 0x64, 0x65, 0x73, 0x63, 0x72, 0x69, 0x70, 0x74, 0x69, 0x6f, 0x6e, 0x22, 0x3a, 0x22, 0x54, 0x68, 0x69, 0x73, 0x20, 0x69, 0x73, 0x20, 0x6d, 0x65, 0x74, 0x61, 0x64, 0x61, 0x74, 0x61, 0x20, 0x66, 0x6f, 0x72, 0x20, 0x74, 0x6f, 0x2d, 0x63, 0x6f, 0x69, 0x6e, 0x22, 0x2c, 0x22, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x5f, 0x75, 0x6e, 0x69, 0x74, 0x73, 0x22, 0x3a, 0x5b, 0x7b, 0x22, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x22, 0x3a, 0x22, 0x74, 0x6f, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x22, 0x2c, 0x22, 0x65, 0x78, 0x70, 0x6f, 0x6e, 0x65, 0x6e, 0x74, 0x22, 0x3a, 0x30, 0x2c, 0x22, 0x61, 0x6c, 0x69, 0x61, 0x73, 0x65, 0x73, 0x22, 0x3a, 0x5b, 0x5d, 0x7d, 0x5d, 0x2c, 0x22, 0x62, 0x61, 0x73, 0x65, 0x22, 0x3a, 0x22, 0x64, 0x75, 0x6d, 0x6d, 0x79, 0x22, 0x2c, 0x22, 0x64, 0x69, 0x73, 0x70, 0x6c, 0x61, 0x79, 0x22, 0x3a, 0x22, 0x64, 0x75, 0x6d, 0x6d, 0x79, 0x63, 0x6f, 0x69, 0x6e, 0x22, 0x2c, 0x22, 0x6e, 0x61, 0x6d, 0x65, 0x22, 0x3a, 0x22, 0x44, 0x55, 0x4d, 0x4d, 0x59, 0x22, 0x2c, 0x22, 0x73, 0x79, 0x6d, 0x62, 0x6f, 0x6c, 0x22, 0x3a, 0x22, 0x44, 0x55, 0x4d, 0x22, 0x7d},
+							Value: []uint8{0x7b, 0x22, 0x64, 0x65, 0x73, 0x63, 0x72, 0x69, 0x70, 0x74, 0x69, 0x6f, 0x6e, 0x22, 0x3a, 0x22, 0x54, 0x68, 0x69, 0x73, 0x20, 0x69, 0x73, 0x20, 0x6d, 0x65, 0x74, 0x61, 0x64, 0x61, 0x74, 0x61, 0x20, 0x66, 0x6f, 0x72, 0x20, 0x74, 0x6f, 0x2d, 0x63, 0x6f, 0x69, 0x6e, 0x22, 0x2c, 0x22, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x5f, 0x75, 0x6e, 0x69, 0x74, 0x73, 0x22, 0x3a, 0x5b, 0x7b, 0x22, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x22, 0x3a, 0x22, 0x74, 0x6f, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x22, 0x2c, 0x22, 0x65, 0x78, 0x70, 0x6f, 0x6e, 0x65, 0x6e, 0x74, 0x22, 0x3a, 0x30, 0x2c, 0x22, 0x61, 0x6c, 0x69, 0x61, 0x73, 0x65, 0x73, 0x22, 0x3a, 0x5b, 0x5d, 0x7d, 0x5d, 0x2c, 0x22, 0x62, 0x61, 0x73, 0x65, 0x22, 0x3a, 0x22, 0x74, 0x6f, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x22, 0x2c, 0x22, 0x64, 0x69, 0x73, 0x70, 0x6c, 0x61, 0x79, 0x22, 0x3a, 0x22, 0x74, 0x6f, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x63, 0x6f, 0x69, 0x6e, 0x22, 0x2c, 0x22, 0x6e, 0x61, 0x6d, 0x65, 0x22, 0x3a, 0x22, 0x44, 0x55, 0x4d, 0x4d, 0x59, 0x22, 0x2c, 0x22, 0x73, 0x79, 0x6d, 0x62, 0x6f, 0x6c, 0x22, 0x3a, 0x22, 0x44, 0x55, 0x4d, 0x22, 0x7d},
+							Index: false,
+						},
+					},
+				},
+			},
+		},
+		"to-denom metadata has been stored": {
+			types.Swap{
+				FromDenom:           "fromdenom",
+				ToDenom:             "todenom",
+				AmountCapForToDenom: sdk.OneInt(),
+				SwapRate:            sdk.OneDec(),
+			},
+			s.toDenomMetadata,
+			func() {
+				bankKeeper.EXPECT().GetDenomMetaData(gomock.Any(), "fromdenom").Return(bank.Metadata{}, true).Times(1)
+				bankKeeper.EXPECT().GetDenomMetaData(gomock.Any(), "todenom").Return(s.toDenomMetadata, true).Times(1)
+			},
+			nil,
+			sdk.Events{
+				sdk.Event{
+					Type: "lbm.fswap.v1.EventSetSwap",
+					Attributes: []abci.EventAttribute{
+						{
+							Key:   []byte("swap"),
+							Value: []uint8{0x7b, 0x22, 0x66, 0x72, 0x6f, 0x6d, 0x5f, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x22, 0x3a, 0x22, 0x66, 0x72, 0x6f, 0x6d, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x22, 0x2c, 0x22, 0x74, 0x6f, 0x5f, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x22, 0x3a, 0x22, 0x74, 0x6f, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x22, 0x2c, 0x22, 0x61, 0x6d, 0x6f, 0x75, 0x6e, 0x74, 0x5f, 0x63, 0x61, 0x70, 0x5f, 0x66, 0x6f, 0x72, 0x5f, 0x74, 0x6f, 0x5f, 0x64, 0x65, 0x6e, 0x6f, 0x6d, 0x22, 0x3a, 0x22, 0x31, 0x22, 0x2c, 0x22, 0x73, 0x77, 0x61, 0x70, 0x5f, 0x72, 0x61, 0x74, 0x65, 0x22, 0x3a, 0x22, 0x31, 0x2e, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x22, 0x7d},
 							Index: false,
 						},
 					},
 				},
 			},
 		},
+		"from-denom does not exist": {
+			types.Swap{
+				FromDenom:           "fakedenom",
+				ToDenom:             "todenom",
+				AmountCapForToDenom: sdk.OneInt(),
+				SwapRate:            sdk.OneDec(),
+			},
+			s.toDenomMetadata,
+			func() {
+				bankKeeper.EXPECT().GetDenomMetaData(gomock.Any(), "fakedenom").Return(bank.Metadata{}, false).Times(1)
+			},
+			sdkerrors.ErrInvalidRequest,
+			sdk.Events{},
+		},
 		"to-denom metadata change not allowed": {
 			types.Swap{
-				FromDenom:           "fromD",
-				ToDenom:             "toD",
+				FromDenom:           "fromdenom",
+				ToDenom:             "change",
 				AmountCapForToDenom: sdk.OneInt(),
 				SwapRate:            sdk.OneDec(),
 			},
@@ -245,21 +349,25 @@ func (s *KeeperTestSuite) TestSetSwap() {
 				Name:        s.toDenomMetadata.Name,
 				Symbol:      s.toDenomMetadata.Symbol,
 			},
-			true,
+			func() {
+				bankKeeper.EXPECT().GetDenomMetaData(gomock.Any(), "fromdenom").Return(bank.Metadata{}, true).Times(1)
+				bankKeeper.EXPECT().GetDenomMetaData(gomock.Any(), "change").Return(s.toDenomMetadata, true).Times(1)
+			},
 			sdkerrors.ErrInvalidRequest,
 			sdk.Events{},
 		},
 	}
 	for name, tc := range testCases {
 		s.Run(name, func() {
 			ctx, _ := s.ctx.CacheContext()
-			err := s.keeper.SetSwap(ctx, tc.swap, s.toDenomMetadata)
-			if tc.existingMetadata {
-				err := s.keeper.SetSwap(ctx, tc.swap, s.toDenomMetadata)
+			tc.malleate()
+			s.keeper.BankKeeper = bankKeeper
+
+			err := s.keeper.SetSwap(ctx, tc.swap, tc.toDenomMeta)
+			if tc.expectedError != nil {
 				s.Require().ErrorIs(err, tc.expectedError)
 				return
 			}
-			s.Require().ErrorIs(err, tc.expectedError)
 			events := ctx.EventManager().Events()
 			s.Require().Equal(tc.expectedEvents, events)
 		})