Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor to use snake_case in proto (backport #1396) #1397

Merged
merged 2 commits into from
May 24, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 24, 2024

Description

closes: #XXXX

  • Use snake_case in proto

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

This is an automatic backport of pull request #1396 done by [Mergify](https://mergify.com).

* chore: refactor to use snake_case in proto to fix mix-use of camelCase and snake_case

* chore: update changelog

(cherry picked from commit 59f7256)

# Conflicts:
#	client/docs/swagger-ui/swagger.yaml
@mergify mergify bot added the conflicts label May 24, 2024
@mergify mergify bot requested review from tkxkd0159 and zemyblue as code owners May 24, 2024 02:59
Copy link
Contributor Author

mergify bot commented May 24, 2024

Cherry-pick of 59f7256 has failed:

On branch mergify/bp/release/v0.49.x/pr-1396
Your branch is up to date with 'origin/release/v0.49.x'.

You are currently cherry-picking commit 59f7256ca.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.md
	modified:   docs/core/proto-docs.md
	modified:   proto/lbm/fswap/v1/query.proto
	modified:   x/fswap/types/query.pb.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   client/docs/swagger-ui/swagger.yaml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested review from 0Tech and jaeseung-bae as code owners May 24, 2024 02:59
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.04%. Comparing base (de3499f) to head (9d64c30).

Current head 9d64c30 differs from pull request most recent head c104fb3

Please upload reports for the commit c104fb3 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v0.49.x    #1397   +/-   ##
================================================
  Coverage            69.04%   69.04%           
================================================
  Files                  671      671           
  Lines                69299    69299           
================================================
  Hits                 47846    47846           
  Misses               19167    19167           
  Partials              2286     2286           

@jaeseung-bae jaeseung-bae self-assigned this May 24, 2024
* chore: refactor to use snake_case in proto to fix mix-use of camelCase and snake_case

* chore: update changelog

(cherry picked from commit 59f7256)

# Conflicts:
#	client/docs/swagger-ui/swagger.yaml
@jaeseung-bae jaeseung-bae added A: improvement Changes in existing functionality C:x/fswap and removed conflicts labels May 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.04%. Comparing base (de3499f) to head (c104fb3).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v0.49.x    #1397   +/-   ##
================================================
  Coverage            69.04%   69.04%           
================================================
  Files                  671      671           
  Lines                69299    69299           
================================================
  Hits                 47846    47846           
  Misses               19167    19167           
  Partials              2286     2286           

@jaeseung-bae jaeseung-bae merged commit 98d243f into release/v0.49.x May 24, 2024
43 checks passed
@jaeseung-bae jaeseung-bae deleted the mergify/bp/release/v0.49.x/pr-1396 branch May 24, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality C:x/fswap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants