Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent param names in FlowClient #470

Closed
greenape opened this issue Mar 12, 2019 · 2 comments · Fixed by #648
Closed

Inconsistent param names in FlowClient #470

greenape opened this issue Mar 12, 2019 · 2 comments · Fixed by #648
Labels
FlowClient Issues related to FlowClient

Comments

@greenape
Copy link
Member

In flowclient,location_event_counts takes an end_date argument. modal_location_from_dates and the meaningful_locations_* functions take a stop_date argument.
@greenape greenape added the FlowClient Issues related to FlowClient label Mar 12, 2019
@maxalbert
Copy link
Contributor

I think there is also a similar inconsistency internally in flowmachine, IIRC. Which version should we go for? (My personal preference would be end_date.)

greenape added a commit that referenced this issue Apr 18, 2019
@greenape
Make all params consistently end_date, instead of stop_date #470
f35b8cd
@greenape greenape mentioned this issue Apr 18, 2019
Merged
8 tasks
BhavinPanch pushed a commit that referenced this issue Apr 24, 2019
@greenape @BhavinPanch
Make all params consistently end_date, instead of stop_date #470
f84dcc0
@jc-harrison
Copy link
Member

Re-opening this as more-recently-exposed queries are inconsistent - subscriber_degree, topup_amount, event_count, displacement, pareto_interactions and nocturnal_events all take start and stop parameters, not start_date and end_date. handset does have start_date and end_date parameters, but the docstring is inconsistent.

@jc-harrison jc-harrison reopened this Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FlowClient Issues related to FlowClient
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consistent params in FlowClient Flowminder/FlowKit
3 participants
@greenape @maxalbert @jc-harrison