Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent params in FlowClient #648

Merged
merged 5 commits into from
Apr 18, 2019
Merged

Consistent params in FlowClient #648

merged 5 commits into from
Apr 18, 2019

Conversation

greenape
Copy link
Member

Closes #470

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Changes the stop_date parameters of modal_location_from_dates and meaningful_locations_* functions to end_date in line with the other functions.

@greenape greenape added FlowClient Issues related to FlowClient refactoring ready-to-merge Label indicating a PR is OK to automerge labels Apr 18, 2019
@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #648 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #648   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files         124      124           
  Lines        6235     6235           
  Branches      660      660           
=======================================
  Hits         5831     5831           
  Misses        280      280           
  Partials      124      124
Impacted Files Coverage Δ
flowclient/flowclient/client.py 94.08% <ø> (ø) ⬆️
.../core/server/query_schemas/meaningful_locations.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bd7801...365944f. Read the comment docs.

@mergify mergify bot merged commit 8a16086 into master Apr 18, 2019
@mergify mergify bot deleted the end-date branch April 18, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FlowClient Issues related to FlowClient ready-to-merge Label indicating a PR is OK to automerge refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent param names in FlowClient
2 participants