4 rows, 5 cols, grow, and ctrl drop/resize #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add row option Users can choose between 1 and 5 rows * add ctrl+drag Holding ctrl during a drag event will show the preview in the grid the mouse is in. Very useful for grids with more than 2 rows.
monitorToLeft is now determined by the screen's x + width equaling the current monitor's x. monitorToRight is now determined by the current monitor's x + width equaling the next monitor's x. This can cause issues if you have 2 stacked monitors with a screen to the left or right that overlaps. But that wouldn't work before anyway. resolves #25
Describe the non-ultrawide cols and rows
only include required files
5 column mode acts just like 4 column mode except 1st maximize uses the center 3 columns and will leave 1 column on either side resolves #83
Use `<Super>`+`<Ctrl>`+`<Arrow>` to grow in that direction if there's room. If no room is available, no action will be performed.
removing brand names from the title at the behest of EGO
|
GrylledCheez
changed the title
|
@phavekes, what do you think? |
While dragging a tile, hold `<CTRL>` and `<SUPER>` will create a start point for a preview. Now you can drag a window to be X cols wide by Y rows tall
Ctrl+Super resizer
|
@Fmstrat, I just added some cool new features. Let me know what you think. |
GrylledCheez
changed the title
|
@Fmstrat, can you at least give the 👀 to let me know you've seen it? |
|
@GrylledCheez I've tested the latest develop, but moving the windows with super-arrows breaks for me. This was working fine prior to this PR. Last tested commit with working super-arrows was 311fc16, I did not test when it broke |
|
How is it broken? |
The windows do not move if I press super+arrow. Only If i first use the mouse to move a window to a corner the super-arrow moves the window. Starting from another position, the windows do not move |
|
Get some debug logs around the bad behavior. |
|
|
Are you able to drag and hold ctrl the release click? |
|
Dragging works fine, but a non-tiled window can not be sent to a tile position with keyboard only anymore. The logs show |
|
confirmed that this affects rows and columns of 2 on standard screens. I'll track it down |
|
please check off these things as they work
|
phavekes
approved these changes
Jul 10, 2023
|
@phavekes, next time do you think you could look at requests on Friday or Saturday? That way I have time to fix them before I go to bed on Sunday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.