Update rosdep #15
Open
Update rosdep #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We hit this issue in our repo as well, any chance this gets committed so we don't have to keep an extra install step on our side? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of
formantto rosdep all of the dependencies can now be captured in thepackage.xml. This means you could install dependencies withrosdep install --from-paths ., butnumpyandopencv-pythonwould be maybe too old of versions. This is one step closer to making this package compliant for standard ROS packaging.The pip install of dependencies is removed from the CMake, since installing dependencies shouldn't really go there. The best example of that is when a package is built on one platform and executed on another, then the dependency install doesn't transfer.