Upgrade AppAuth-iOS to 1.0.0 #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Jun 28, 2019
thymikee
reviewed
Jun 28, 2019
README.md
Outdated
|
|
||
| Then run `pod install`. Note that version 0.94 is the first of the library to support iOS 11. | ||
| Then run `pod install`. |
There was a problem hiding this comment.
FYI, all instructions about linking on both paltforms are obsolete in RN 0.60 if the library works with autolinking. All you need to document now is:
- running
pod installafter adding the dep - how to use with Carthage or anything that is not CocoaPods or manual link
There was a problem hiding this comment.
You're right, I'll update the instructions. Thanks for all your help on this!
kadikraman
force-pushed
the
feature/upgrade-appauth-ios
branch
from
1c32f12
to
ad05491
Compare
|
Note - next major release will have RN0.60 as a peer dependency, so the instructions for <RN0.60 will be removed before then. I'm leaving both instructions in (for now), for users who are installing the library between now and the next major release, and are using the instructions from the master branch on GitHub. |
|
Released in v5.0.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #337
Fixes #339
Description
Upgrades the native AppAuth-iOS dependency.
Note: this will have to be a major release, due to a typo fix in a method name